Re: RFR: 8151901: test/tools/pack200/Pack200Test fails on verifying native unpacked JAR

> On Sep 2, 2016, at 10:14 AM, Kumar Srinivasan > wrote: > > Hi John, > > Please review the amended patch, based on our discussions. > http://cr.openjdk.java.net/~ksrini/8151901/webrev.01/ > > > Highlights: > * adjust the ordering of th

Re: RFR: 8151901: test/tools/pack200/Pack200Test fails on verifying native unpacked JAR

Hi John, Please review the amended patch, based on our discussions. http://cr.openjdk.java.net/~ksrini/8151901/webrev.01/ Highlights: * adjust the ordering of the InnerClass and BootStrapMethods computations * enabled the test, and disabled memory leak check, which causes intermittent failur

Re: RFR: 8151901: test/tools/pack200/Pack200Test fails on verifying native unpacked JAR

Hi, Kumar So far this test is in ProblemList.txt: tools/pack200/Pack200Test.java 8059906,8151901 generic-all Will it be removed from ProblemList.txt in this fix? Thanks, Amy On 3/22/16 3:49 AM, Kumar Srinivasan wrote: Hi John, This patch contains fixes for two bugs: 8151901: test/tools/pack2

Re: RFR: 8151901: test/tools/pack200/Pack200Test fails on verifying native unpacked JAR

Thanks for the review, but your patches appears to have caused regressions, I will need to look at it this further, when I get some more cycles. Thanks Kumar Good. Please change the comment: s/null, no tuple change, force recomputation/null, drop ICs attribute, force CP recomputation/ Reor

Re: RFR: 8151901: test/tools/pack200/Pack200Test fails on verifying native unpacked JAR

Good. Please change the comment: s/null, no tuple change, force recomputation/null, drop ICs attribute, force CP recomputation/ Reordering BSMs and ICs should work. The BSMs may need extra ICs, but ICs cannot depend on BSMs. I wonder why we did the other order first? I guess because that is wha

RFR: 8151901: test/tools/pack200/Pack200Test fails on verifying native unpacked JAR

Hi John, This patch contains fixes for two bugs: 8151901: test/tools/pack200/Pack200Test fails on verifying native unpacked JAR 8062335: Pack200 Java implementation differs from C version, outputs unused UTF8 for BootstrapMethods Note: The test case exhibits both of the above. With this the