This seems to have caused a number of failures in hotspot testing as
thrown ClassFormatErrors seem to have been replaced by LinkageError.
https://bugs.openjdk.java.net/browse/JDK-8173915
David
Thank you Kumar and Alan.
Just pushed the fix. All the related tests from "core" and "pit" testset
Thank you Kumar and Alan.
Just pushed the fix. All the related tests from "core" and "pit" testset are
passed.
Regards,
Ramanand.
-Original Message-
From: Kumar Srinivasan
Sent: Tuesday, January 31, 2017 9:53 PM
To: Ramanand Patil
Cc: Alan Bateman
Approved, please make sure you have run all the
jprt -testset pit tests.
Kumar
On 1/30/2017 5:05 AM, Alan Bateman wrote:
On 30/01/2017 12:11, Ramanand Patil wrote:
Thank you Alan.
I have eliminated the inner catch block for LinkageError. Here is the
updated webrev:
On 30/01/2017 12:11, Ramanand Patil wrote:
Thank you Alan.
I have eliminated the inner catch block for LinkageError. Here is the updated
webrev:
http://cr.openjdk.java.net/~rpatil/8167063/webrev.04
I think this looks right now.
-Alan
Thank you Alan.
I have eliminated the inner catch block for LinkageError. Here is the updated
webrev:
http://cr.openjdk.java.net/~rpatil/8167063/webrev.04
Regards,
Ramanand.
-Original Message-
From: Alan Bateman
Sent: Sunday, January 29, 2017 1:06 AM
To: Ramanand Patil
On 27/01/2017 12:52, Ramanand Patil wrote:
Thank you Alan and Kumar for your review.
Here is the updated webrev: http://cr.openjdk.java.net/~rpatil/8167063/webrev.03
Changes done:
1. LinkageError in method loadMainClass is handled separately and with a new
message in launcher.properties
2.
Thank you Alan and Kumar for your review.
Here is the updated webrev: http://cr.openjdk.java.net/~rpatil/8167063/webrev.03
Changes done:
1. LinkageError in method loadMainClass is handled separately and with a new
message in launcher.properties
2. Test case updated to print the error
116 if (result.isOK()) {
117 throw new Exception("Test Passed Unexpectedly!");
118 } else if (result.contains("JNI error")) {
119 result.testOutput.forEach(System.err::println);
120 throw new Exception("Test Failed with JNI error!");
121
On 25/01/2017 10:10, Ramanand Patil wrote:
Hi Kumar,
Thank you for the review and suggestions for the test case.
Here is the updated Webrev:
http://cr.openjdk.java.net/~rpatil/8167063/webrev.02/
I see Kumar is looking at the test, I'll stick with LauncherHelper.
The update to
Hi Kumar,
Thank you for the review and suggestions for the test case.
Here is the updated Webrev:
http://cr.openjdk.java.net/~rpatil/8167063/webrev.02/
Regards,
Ramanand.
-Original Message-
From: Kumar Srinivasan
Sent: Tuesday, January 24, 2017 2:50 AM
To: Ramanand Patil
Hi Ramanand,
test/tools/launcher/LauncherMessageTest.java
1)
116 String[] commands = {"java", "--module-path", modules.getPath(),
117 "-m", "mod.b/pkgB.ClassB"};
The execution PATH may or may not contain the JAVA_HOME_UNDER_TEST/bin,
so the right "java" may not be picked
Hi Alan,
Thank you for the review.
My comments are inline and Webrev is updated here:
http://cr.openjdk.java.net/~rpatil/8167063/webrev.01/
Change Summary:
- Removed SecurityException handling
- Updated the error message in launcher.properties
- Removed loadModuleMainClass0 method and moved the
On 20/01/2017 13:21, Ramanand Patil wrote:
Hi all,
Please review the following bug fix:
Bug: https://bugs.openjdk.java.net/browse/JDK-8167063
Webrev: http://cr.openjdk.java.net/~rpatil/8167063/webrev.00/
Handled the SecurityException and LinkageError which can be thrown from
Hi all,
Please review the following bug fix:
Bug: https://bugs.openjdk.java.net/browse/JDK-8167063
Webrev: http://cr.openjdk.java.net/~rpatil/8167063/webrev.00/
Handled the SecurityException and LinkageError which can be thrown from
Class.forName(...) method used in LauncherHelper.java and added
14 matches
Mail list logo