Re: RFR: 8174735 Update JAX-WS RI integration to latest version

2017-02-16 Thread Roman Grigoriadi
Hi Daniel, On 02/16/2017 11:39 AM, Daniel Fuchs wrote: Hi Aleksej, On 15/02/17 23:49, Aleks Efimov wrote: Hi, The new webrev with addressed comments was uploaded here: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8174735/01 This is probably a question for the upstream project,

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

2017-02-16 Thread Daniel Fuchs
Hi Aleksej, On 15/02/17 23:49, Aleks Efimov wrote: Hi, The new webrev with addressed comments was uploaded here: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8174735/01 This is probably a question for the upstream project, but I'm puzzled by this change:

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

2017-02-15 Thread Lance Andersen
Hi Roman, Aleks, This looks better. There are several files in Datatype/helper such as arameterlessDatatypeBuilder.java. who had the copyright date changed but there are not other updates. Not sure that you want that Best Lance > On Feb 15, 2017, at 7:14 PM, Mandy Chung

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

2017-02-15 Thread Mandy Chung
I checked module-info.java, default.policy and also the tools `—-release` option. This version looks fine to me. Mandy > On Feb 15, 2017, at 3:49 PM, Aleks Efimov wrote: > > Hi, > > The new webrev with addressed comments was uploaded here: >

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

2017-02-15 Thread Aleks Efimov
Hi, The new webrev with addressed comments was uploaded here: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8174735/01 Best, Aleksej On 15/02/17 15:42, Roman Grigoriadi wrote: Hi Mandy, On 02/14/2017 11:53 PM, Mandy Chung wrote: On Feb 14, 2017, at 4:00 AM, Roman Grigoriadi

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

2017-02-15 Thread Lukas Jungmann
Hi, comments wrt JSR-250 inline, also adding Linda who maintains it these days to the loop On 2/15/17 2:36 PM, Roman Grigoriadi wrote: Adding Lukas On 02/15/2017 01:40 PM, Roman Grigoriadi wrote: Hi Lance, On 02/14/2017 09:28 PM, Lance Andersen wrote: Hi Roman, I made a pass through

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

2017-02-15 Thread Roman Grigoriadi
Adding Lukas On 02/15/2017 01:40 PM, Roman Grigoriadi wrote: Hi Lance, On 02/14/2017 09:28 PM, Lance Andersen wrote: Hi Roman, I made a pass through the changes. And here are some general comments which are mostly minor in nature…. HTH Best Lance --

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

2017-02-15 Thread Roman Grigoriadi
Hi Mandy, On 02/14/2017 11:53 PM, Mandy Chung wrote: On Feb 14, 2017, at 4:00 AM, Roman Grigoriadi wrote: Hi, Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo. JBS: https://bugs.openjdk.java.net/browse/JDK-8174735 Webrev:

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

2017-02-15 Thread Roman Grigoriadi
Hi Lance, On 02/14/2017 09:28 PM, Lance Andersen wrote: Hi Roman, I made a pass through the changes. And here are some general comments which are mostly minor in nature…. HTH Best Lance -- JAXBRIContext.java: - The comment “If true, despite of the specification….”;

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

2017-02-14 Thread Lance Andersen
Hi Roman, I made a pass through the changes. And here are some general comments which are mostly minor in nature…. HTH Best Lance -- JAXBRIContext.java: - The comment “If true, despite of the specification….”; This does not read well can this be clarified?

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

2017-02-14 Thread Alan Bateman
On 14/02/2017 12:28, Roman Grigoriadi wrote: On 02/14/2017 01:05 PM, Alan Bateman wrote: Is the webrev missing the update to java.base's module-info.java? I assume we can drop the exporting of sun.reflect.misc to java.xml.ws. Thanks Alan, Mandy's patch for jaxws own MethodUtil is integrated,

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

2017-02-14 Thread Roman Grigoriadi
On 02/14/2017 01:05 PM, Alan Bateman wrote: Is the webrev missing the update to java.base's module-info.java? I assume we can drop the exporting of sun.reflect.misc to java.xml.ws. Thanks Alan, Mandy's patch for jaxws own MethodUtil is integrated, so sun.reflect.misc export should now be

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

2017-02-14 Thread Alan Bateman
On 14/02/2017 12:00, Roman Grigoriadi wrote: Hi, Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo. JBS: https://bugs.openjdk.java.net/browse/JDK-8174735 Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8174735/00/ You can find change list in the

RFR: 8174735 Update JAX-WS RI integration to latest version

2017-02-14 Thread Roman Grigoriadi
Hi, Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo. JBS: https://bugs.openjdk.java.net/browse/JDK-8174735 Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8174735/00/ You can find change list in the description of JBS and its linked issues. Most diffs are