Hi,
The CSR for this change is approved now.
https://bugs.openjdk.java.net/browse/JDK-8191477
If there aren't any more objections, I will push this.
Webrev rebased and with updated 2018 copyright messages:
http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.08/
Best regards,
k.java.net; 'compiler-...@openjdk.java.net'
> <compiler-...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
> Subject: Re: RFR: 8189102: All tools should support -?, -h and --help
>
> Hi,
>
> Besides my
eability-dev (serviceability-
d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
Subject: Re: RFR: 8189102: All tools should support -?, -h and --help
Hi,
I looked at some of the components I maintain, and they look good.
Wrt. the test:
1. The local variables/fields don't comp
com>; serviceability-dev
> (serviceability-...@openjdk.java.net) d...@openjdk.java.net>; compiler-...@openjdk.java.net; core-libs-
> d...@openjdk.java.net
> Subject: Re: RFR: 8189102: All tools should support -?, -h and --help
>
> Thumbs up for JShell changes.
>
> -Rob
rviceability-dev (serviceability-
>> d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
>> Subject: Re: RFR: 8189102: All tools should support -?, -h and --help
>>
>> Hi,
>>
>> I looked at some of the components I maintain, and they look g
-...@openjdk.java.net'
> <compiler-...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
> Subject: Re: RFR: 8189102: All tools should support -?, -h and --help
>
> Hi,
>
> I looked at some of the compone
Hi Kumar,
Thanks for looking at my change!
> I looked at some of the components I maintain, and they look good.
May I ask which these are? So I can account whether all parts have been
reviewed?
> 1. The local variables/fields don't comply with the coding conventions,
> we have been
>
Hi,
I looked at some of the components I maintain, and they look good.
Wrt. the test:
1. The local variables/fields don't comply with the coding conventions,
we have been
following in the JDK.
2. Hmm, someone parked a .ini file in bin directory, later removed,
perhaps on windows
-...@openjdk.java.net;
> serviceability-dev (serviceability-...@openjdk.java.net) d...@openjdk.java.net>
> Subject: Re: RFR: 8189102: All tools should support -?, -h and --help
>
> Hi Goetz
>
> I would just remove it.
>
> Thanks
> Max
>
> > On Nov 22, 2017, at 2:5
.w...@oracle.com]
>> Sent: Monday, November 20, 2017 3:49 PM
>> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>
>> Cc: core-libs-dev@openjdk.java.net; compiler-...@openjdk.java.net;
>> serviceability-dev (serviceability-...@openjdk.java.net) > d...@openjdk.java.net
e.com]
> Sent: Monday, November 20, 2017 3:49 PM
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>
> Cc: core-libs-dev@openjdk.java.net; compiler-...@openjdk.java.net;
> serviceability-dev (serviceability-...@openjdk.java.net) d...@openjdk.java.net>
> Subject: Re: RFR
Print this help message
> jstatd -?|-h|--help
>
>
>> -Original Message-
>> From: Weijun Wang [mailto:weijun.w...@oracle.com]
>> Sent: Sonntag, 19. November 2017 01:28
>> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>
>> Cc: core-libs
On 20/11/2017 13:41, Lindenmaier, Goetz wrote:
:
The deprecated tools are
orbd,
wsgen
wsimport
schemagen
Is that correct?
Yes, plus xjc, idlj, servertool and tnameserv (the full list is in the
draft JEP that I linked to).
-Alan
; Sent: Sonntag, 19. November 2017 01:28
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>
> Cc: core-libs-dev@openjdk.java.net; compiler-...@openjdk.java.net;
> serviceability-dev (serviceability-...@openjdk.java.net) d...@openjdk.java.net>
> Subject: Re: RFR: 8189102: Al
ceability-...@openjdk.java.net>
> Subject: Re: RFR: 8189102: All tools should support -?, -h and --help
>
> On 17/11/2017 11:23, Lindenmaier, Goetz wrote:
> > Hi,
> >
> > please review this change. I also filed a CSR for this:
> > http://cr.openjdk.jav
penjdk.java.net>
> Subject: Re: RFR: 8189102: All tools should support -?, -h and --help
>
> JShell changes —
>
> The code change is fine.
>
> The help change in the properties file is not consistent with the other items,
> note:--help-
om>; core-libs-
> d...@openjdk.java.net; 'compiler-...@openjdk.java.net' d...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
> Subject: Re: RFR: 8189102: All tools should support -?, -h and --help
>
> Goetz,
&
We are already in a hybrid world of old-style and new-style options :-(
All the new module-related options added in JDK 9 are "new style",
following the guidelines of JEP 293.
It does not make sense to add "--" to some of the older tools, that may
be going away at some point, and while we
On 11/18/17 12:41 AM, Alan Bateman wrote:
A question for Jon Gibbons: In JEP 293 the guideline is that tools
should support `--help`. Do you think this should be expanded to
include `-help`, and `-?` (and maybe `-h` where it make sense)?
I think we should standardize on --help, and -h
I am OK with all commands supporting --help, but I am not sure if every tool
should show it on the help screen if the tools's other options are still using
the old single-"-" style. It looks like the tools are half-converted.
Is there a timetable to add "--" support to all tools?
Thanks
Max
>
On 17/11/2017 11:23, Lindenmaier, Goetz wrote:
Hi,
please review this change. I also filed a CSR for this:
http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.02/
Bug: https://bugs.openjdk.java.net/browse/JDK-8189102
CSR: https://bugs.openjdk.java.net/browse/JDK-8191477
See the
JShell changes —
The code change is fine.
The help change in the properties file is not consistent with the other items,
note:--help-extra, -X Print help on…
so this should be: —help, -h, -?
Or, if there is a tool-wide standard, then the —help-extra entry should be
Goetz,
I understand why you might want to ensure that a basic set of help
options is supported,
but I don't understand why that justifies removing older options, like
"-help" for many tools.
In addition, I notice the CSR says:
*Compatibility Risk Description:*
Hi,
please review this change. I also filed a CSR for this:
http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.02/
Bug: https://bugs.openjdk.java.net/browse/JDK-8189102
CSR: https://bugs.openjdk.java.net/browse/JDK-8191477
See the webrev for a detailed description of the changes.
24 matches
Mail list logo
