Re: RFR: 8196750 [Testbug] tools/launcher tests need to tolerate unrelated warnings

2018-04-05 Thread Kumar Srinivasan
Looks good, thanks for doing this!. Kumar On 4/4/2018 5:09 PM, Andrey Nazarov wrote: On 22 Mar 2018, at 07:18, Kumar Srinivasan wrote: David, Why would the VM emit these warnings if the deprecated vm flag is not being used ? Andrey, As for the reviews I am

Re: RFR: 8196750 [Testbug] tools/launcher tests need to tolerate unrelated warnings

2018-04-04 Thread Andrey Nazarov
> On 22 Mar 2018, at 07:18, Kumar Srinivasan > wrote: > > David, > > Why would the VM emit these warnings if the deprecated vm flag > is not being used ? > > Andrey, > As for the reviews I am ok with InfoStreams, wrt. ToolOpts it is not at all > apparent, >

Re: RFR: 8196750 [Testbug] tools/launcher tests need to tolerate unrelated warnings

2018-03-22 Thread David Holmes
On 23/03/2018 12:18 AM, Kumar Srinivasan wrote: David, Why would the VM emit these warnings if the deprecated vm flag is not being used ? The warnings are not deprecation warnings. The warnings are for flags that should have been made obsolete in this version but are still present. It is a

Re: RFR: 8196750 [Testbug] tools/launcher tests need to tolerate unrelated warnings

2018-03-22 Thread Kumar Srinivasan
David, Why would the VM emit these warnings if the deprecated vm flag is not being used ? Andrey, As for the reviews I am ok with InfoStreams, wrt. ToolOpts it is not at all apparent, maybe more comments explaining what is going on ? Kumar Hi Andrei, On 22/03/2018 11:12 AM, Andrey

Re: RFR: 8196750 [Testbug] tools/launcher tests need to tolerate unrelated warnings

2018-03-21 Thread David Holmes
On 22/03/2018 12:52 PM, Andrei Nazarov wrote: On Mar 21, 2018 19:13, David Holmes wrote: Hi Andrei, On 22/03/2018 11:12 AM, Andrey Nazarov wrote: > Hi, > > Please review fix in launcher tests. > > Review:

Re: RFR: 8196750 [Testbug] tools/launcher tests need to tolerate unrelated warnings

2018-03-21 Thread David Holmes
Hi Andrei, On 22/03/2018 11:12 AM, Andrey Nazarov wrote: Hi, Please review fix in launcher tests. Review: http://cr.openjdk.java.net/~anazarov/JDK-8196750/webrev/ Bug: https://bugs.openjdk.java.net/browse/JDK-8196750?filter=-1 test/jdk/tools/launcher/ToolsOpts.java I don't understand how

RFR: 8196750 [Testbug] tools/launcher tests need to tolerate unrelated warnings

2018-03-21 Thread Andrey Nazarov
Hi, Please review fix in launcher tests. Review: http://cr.openjdk.java.net/~anazarov/JDK-8196750/webrev/ Bug: https://bugs.openjdk.java.net/browse/JDK-8196750?filter=-1 —Thanks, Andrei