Hi, Vladimir
Thanks for the explanation of the changes to LONG_RUN_LENGTHS and
SHORT_RUN_LENGTHS.
I've incorporated the other suggested changes:
http://cr.openjdk.java.net/~bchristi/8226297/webrev10/
-Brent
On 10/24/19 4:30 AM, Vladimir Yaroslavskiy wrote:
Hi Brent,
See my comments inline
Hi Brent,
See my comments inline
>Oct 24б 2019, 7:42 +03:00 от Brent Christian :
>
>Hi,
>
>I've created a webrev of the latest test changes that Vladimir sent me:
>
>http://cr.openjdk.java.net/~bchristi/8226297/webrev09-testUpdate/
>
>(I also created an incremental webrev[1] along the way, in
Hi,
I've created a webrev of the latest test changes that Vladimir sent me:
http://cr.openjdk.java.net/~bchristi/8226297/webrev09-testUpdate/
(I also created an incremental webrev[1] along the way, in case that's
helpful to anyone).
I have just a few comments:
Hi, Vladimir
On 10/8/19 3:18 PM, Vladimir Yaroslavskiy wrote:
The following renaming changes are important
and should be kept. My explanation is here
> ...
Thanks for the explanation - much appreciated.
* Other changes, like failed -> fail, i++ -> ++i,
and TypeConverter, FloatBuilder,
Hi Brent,
Thank you for review, see my comments inline:
>Oct 8, 2019, 1:53 +03:00 от Brent Christian :
>
>Hi, Vladimir
>
>I've read through the changes[1]. I have the following comments:
>
>---
>src/java.base/share/classes/java/util/Arrays.java
>
>* Regarding the indentation changes in the
Hi, Vladimir
I've read through the changes[1]. I have the following comments:
---
src/java.base/share/classes/java/util/Arrays.java
* Regarding the indentation changes in the equals() methods:
- * {@code new Double(d1).equals(new Double(d2))}
+ * {@code new Double(d1).equals(new
Hi,
I received an update from Vladimir:
---
"I investigated approach with adaptive threshold for mixed insertion sort
and have the following results.
New version shows the same gain for large arrays
and has few percents of speed up for small arrays:
total gain:
Hi Brent,
I made a manual comparison of your webrev.4 and my previous patch.
- I noticed plenty of javadoc / comment changes that seem totally
appropriate in Arrays class: ok for me.
- You also fixed the problem with the ForkJoinPool field: good.
- No change in the DualPivotQuickSort class except
On 8/6/19 12:47 PM, Vladimir Yaroslavskiy wrote:
I moved Object sorting related stuff after primitives sorting methods
to separate functionality logically.
Sure, fine to keep that all together. I can move that back:
http://cr.openjdk.java.net/~bchristi/8226297/webrev04/
The order of
Hi Brent,,
I moved Object sorting related stuff after primitives sorting methods
to separate functionality logically.
The order of methods in my version is:
1. primitives (sequential sorting)
- int
- long
- byte
- char
- short
- float
- double
2. primitives (parallel sorting)
- int
- long
-
Hi, Laurent
I'm not sure what exactly is causing the problem, but here's my hunch:
In Vladimir's version of Arrays.java:
MIN_ARRAY_SORT_GRAN
NaturalOrder
rangeCheck
got moved around, but were unchanged.
In the interest of keeping the change as simple as possible, I restored
these to
Hi Brent,
Thank you for sponsoring this patch.
I tried to compare your webrev against my latest (diff patch files) but it
gives me too many changes lines.
Do you have another idea to see incremental changes only ?
(anyway I can compare raw files)
Thanks,
Laurent
Le lun. 5 août 2019 à 23:43,
Hi,
Please review Vladimir Yaroslavskiy's changes to DualPivotQuickSort
(seen earlier[1] on this alias). I will be sponsoring this change.
I have a webrev against jdk-jdk here:
http://cr.openjdk.java.net/~bchristi/8226297/webrev03-rfr/
(Note that I did a little re-ordering, and removed some
13 matches
Mail list logo
