Re: RFR: 8235730: Incorrect javadoc in MatchKind

2019-12-11 Thread Stuart Marks
Indeed it is, thanks. Resolved. s'marks On 12/11/19 8:41 AM, Stefan Zobel wrote: FWIW, I believe this bug is duplicate of https://bugs.openjdk.java.net/browse/JDK-8213238 Regards, Stefan Am Mi., 11. Dez. 2019 um 17:07 Uhr schrieb Arthur Eubanks : Hi, could I get a review for a trivial and

Re: RFR: 8235730: Incorrect javadoc in MatchKind

2019-12-11 Thread Stefan Zobel
FWIW, I believe this bug is duplicate of https://bugs.openjdk.java.net/browse/JDK-8213238 Regards, Stefan Am Mi., 11. Dez. 2019 um 17:07 Uhr schrieb Arthur Eubanks : > > Hi, could I get a review for a trivial and tiny doc fix? > > Bug: https://bugs.openjdk.java.net/browse/JDK-8235730 > Webrev:

Re: RFR: 8235730: Incorrect javadoc in MatchKind

2019-12-11 Thread Martin Buchholz
Looks good to me. My own policy is to never update Oracle copyright years for changes by a non-Oracle employee. On Wed, Dec 11, 2019 at 8:30 AM Pavel Rappo wrote: > Looks good to me. Trivially, update the copyright years before pushing. > > This is one of those changes that decrease the

Re: RFR: 8235730: Incorrect javadoc in MatchKind

2019-12-11 Thread Pavel Rappo
Looks good to me. Trivially, update the copyright years before pushing. This is one of those changes that decrease the entropy, but have little visible effects on the outside world. Neither MatchOps nor MatchOps.MatchKind type should be visible in the online API docs. P.S. I'm not a Reviewer.