Re: RFR: 8236641: Improve Set.of(...).iterator() warmup characteristics

2020-01-21 Thread Claes Redestad
On 2020-01-21 21:39, Stuart Marks wrote: http://cr.openjdk.java.net/~redestad/8236641/open.02/ The new version looks great. Thanks for the update. Thanks! Pushed. /Claes

Re: RFR: 8236641: Improve Set.of(...).iterator() warmup characteristics

2020-01-21 Thread Stuart Marks
On 1/19/20 11:04 AM, Claes Redestad wrote: On 2020-01-19 20:03, Claes Redestad wrote: Uploaded new version with improved comments here: http://cr.openjdk.java.net/~redestad/8236641/open.02/ The new version looks great. Thanks for the update. s'marks

Re: RFR: 8236641: Improve Set.of(...).iterator() warmup characteristics

2020-01-19 Thread Claes Redestad
On 2020-01-19 20:03, Claes Redestad wrote: Uploaded new version with improved comments here: http://cr.openjdk.java.net/~redestad/8236641/open.02/

Re: RFR: 8236641: Improve Set.of(...).iterator() warmup characteristics

2020-01-19 Thread Claes Redestad
On 2020-01-18 17:51, Stuart Marks wrote: On 1/16/20 8:21 AM, Claes Redestad wrote: I've cleaned up a bit (SALT can be made into a long to reduce casts etc), and rolled it into the current patch: http://cr.openjdk.java.net/~redestad/8236641/open.01/ OK, I think this makes sense. But I did

Re: RFR: 8236641: Improve Set.of(...).iterator() warmup characteristics

2020-01-18 Thread Stuart Marks
On 1/16/20 8:21 AM, Claes Redestad wrote: I've cleaned up a bit (SALT can be made into a long to reduce casts etc), and rolled it into the current patch: http://cr.openjdk.java.net/~redestad/8236641/open.01/ OK, I think this makes sense. But I did have to stare at the code for a while to

Re: RFR: 8236641: Improve Set.of(...).iterator() warmup characteristics

2020-01-16 Thread Claes Redestad
Florian, On 2020-01-16 11:20, Florian Weimer wrote: * Claes Redestad: we're doing plenty of iterations over Set.of() instances during bootstrap, which makes these operations show up prominently in startup profiles. This patch refactors a few hot methods to get a measureable startup

Re: RFR: 8236641: Improve Set.of(...).iterator() warmup characteristics

2020-01-16 Thread Florian Weimer
* Claes Redestad: > we're doing plenty of iterations over Set.of() instances during > bootstrap, which makes these operations show up prominently in > startup profiles. This patch refactors a few hot methods to get a > measureable startup improvement without regressing on targeted >

Re: RFR: 8236641: Improve Set.of(...).iterator() warmup characteristics

2020-01-15 Thread John Rose
> On Jan 15, 2020, at 5:46 PM, Stuart Marks wrote: > >  > >> On 1/13/20 8:03 AM, Claes Redestad wrote: >> we're doing plenty of iterations over Set.of() instances during >> bootstrap, which makes these operations show up prominently in >> startup profiles. This patch refactors a few hot

Re: RFR: 8236641: Improve Set.of(...).iterator() warmup characteristics

2020-01-15 Thread Stuart Marks
On 1/13/20 8:03 AM, Claes Redestad wrote: we're doing plenty of iterations over Set.of() instances during bootstrap, which makes these operations show up prominently in startup profiles. This patch refactors a few hot methods to get a measureable startup improvement without regressing on

RFR: 8236641: Improve Set.of(...).iterator() warmup characteristics

2020-01-13 Thread Claes Redestad
Hi, we're doing plenty of iterations over Set.of() instances during bootstrap, which makes these operations show up prominently in startup profiles. This patch refactors a few hot methods to get a measureable startup improvement without regressing on targeted microbenchmarks. Bug: