Re: RFR: 8240903: Add a regression test for JDK-8240734 [v3]
On Fri, 25 Mar 2022 11:54:52 GMT, Alan Bateman wrote: > The existing tests for the jmod tool are in test/jdk/tools/jmod. > HashesTest.java might provide inspiration to avoid introducing a shell test. Hi, Alan I have rewritten this test in Java in the latest commit. - PR: https://git.openjdk.java.net/jdk/pull/7948
Re: RFR: 8240903: Add a regression test for JDK-8240734 [v3]
On Fri, 25 Mar 2022 05:16:28 GMT, Dongbo He wrote: >> This creates a regression test for >> [JDK-8240734](https://bugs.openjdk.java.net/browse/JDK-8240734). This was >> once blocked >> by a time stamp issue which has been resolved by: [JDK-8276766 >> ](https://bugs.openjdk.java.net/browse/JDK-8276766) >> >> We found the issue can be produced stably with at least 64 modules. >> Note that we need to add the --date jmod option to avoid the timestamp issue. >> >> Testing: >> Added test case fails without fix for JDK-8240734, and passes otherwise. >> Tested with tier2 on linux x86. > > Dongbo He has updated the pull request incrementally with one additional > commit since the last revision: > > Get date by 'date +%Y-%m-%dT%H:%M:%S%:z' The existing tests for the jmod tool are in test/jdk/tools/jmod. HashesTest.java might provide inspiration to avoid introducing a shell test. - PR: https://git.openjdk.java.net/jdk/pull/7948
Re: RFR: 8240903: Add a regression test for JDK-8240734 [v3]
> This creates a regression test for > [JDK-8240734](https://bugs.openjdk.java.net/browse/JDK-8240734). This was > once blocked > by a time stamp issue which has been resolved by: [JDK-8276766 > ](https://bugs.openjdk.java.net/browse/JDK-8276766) > > We found the issue can be produced stably with at least 64 modules. > Note that we need to add the --date jmod option to avoid the timestamp issue. > > Testing: > Added test case fails without fix for JDK-8240734, and passes otherwise. > Tested with tier2 on linux x86. Dongbo He has updated the pull request incrementally with one additional commit since the last revision: Get date by 'date +%Y-%m-%dT%H:%M:%S%:z' - Changes: - all: https://git.openjdk.java.net/jdk/pull/7948/files - new: https://git.openjdk.java.net/jdk/pull/7948/files/b2a1c843..aea79a40 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7948=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7948=01-02 Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/7948.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7948/head:pull/7948 PR: https://git.openjdk.java.net/jdk/pull/7948
