Re: RFR: 8244778: Archive full module graph in CDS [v3]

2020-09-09 Thread Coleen Phillimore
On Wed, 9 Sep 2020 18:46:33 GMT, Lois Foltan wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Feedback from Coleen > > Thanks Ioi for addressing my review comments. Overall, looks great! Ok thanks! So many emails

Re: RFR: 8244778: Archive full module graph in CDS [v3]

2020-09-09 Thread Ioi Lam
On Tue, 8 Sep 2020 17:32:44 GMT, Coleen Phillimore wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Feedback from Coleen > > src/hotspot/share/classfile/classLoaderDataShared.cpp line 171: > >> 169: } >> 170: >> 171:

Re: RFR: 8244778: Archive full module graph in CDS [v3]

2020-09-09 Thread Ioi Lam
> This is the same patch as > [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) > published in > [hotspot-runtime-...@openjdk.java.net](https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/041496.html). > The