On Sun, 24 Jan 2021 20:14:04 GMT, Martin Buchholz wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix typo, clarify asserts disabled, test prefGrowth==0
>
> Marked as reviewed by martin (Reviewer).
The new docs
On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote:
>> This rewrites the doc of ArraysSupport.newLength, adds detail to the
>> exception message, and adds a test. In addition to some renaming and a bit
>> of refactoring of the actual code, I also made two changes of substance to
>> the code:
On Fri, 4 Dec 2020 17:31:20 GMT, Stuart Marks wrote:
>> src/java.base/share/classes/jdk/internal/util/ArraysSupport.java line 654:
>>
>>> 652: return SOFT_MAX_ARRAY_LENGTH;
>>> 653: } else {
>>> 654: return minLength;
>>
>> Isn't this last `else if... then..
On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote:
>> This rewrites the doc of ArraysSupport.newLength, adds detail to the
>> exception message, and adds a test. In addition to some renaming and a bit
>> of refactoring of the actual code, I also made two changes of substance to
>> the code:
On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote:
>> This rewrites the doc of ArraysSupport.newLength, adds detail to the
>> exception message, and adds a test. In addition to some renaming and a bit
>> of refactoring of the actual code, I also made two changes of substance to
>> the code:
On Wed, 9 Dec 2020 00:32:37 GMT, Paul Sandoz wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix typo, clarify asserts disabled, test prefGrowth==0
>
>
On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote:
>> This rewrites the doc of ArraysSupport.newLength, adds detail to the
>> exception message, and adds a test. In addition to some renaming and a bit
>> of refactoring of the actual code, I also made two changes of substance to
>> the code:
On Wed, 9 Dec 2020 00:32:44 GMT, Paul Sandoz wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix typo, clarify asserts disabled, test prefGrowth==0
>
> Marked as reviewed by psandoz (Reviewer).
@Martin-Buchholz
On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote:
>> This rewrites the doc of ArraysSupport.newLength, adds detail to the
>> exception message, and adds a test. In addition to some renaming and a bit
>> of refactoring of the actual code, I also made two changes of substance to
>> the code:
On Tue, 8 Dec 2020 06:14:35 GMT, Stuart Marks wrote:
>> This rewrites the doc of ArraysSupport.newLength, adds detail to the
>> exception message, and adds a test. In addition to some renaming and a bit
>> of refactoring of the actual code, I also made two changes of substance to
>> the code:
On Tue, 8 Dec 2020 00:48:55 GMT, Stuart Marks wrote:
>> The algorithm can be well defined for minGrowth and prefGrowth == 0 without
>> extra checks or exceptions with a careful look at the inequality checks.
>> For example, as currently coded, if both are zero, it returns
>>
> This rewrites the doc of ArraysSupport.newLength, adds detail to the
> exception message, and adds a test. In addition to some renaming and a bit of
> refactoring of the actual code, I also made two changes of substance to the
> code:
>
> 1. I fixed a problem with overflow checking. In the
12 matches
Mail list logo
