> Hi, > > Please review the changes for the subject issue. This is to enhance the > java.time package to support day periods, such as "in the morning", defined > in CLDR. It will add a new pattern character 'B' and its supporting builder > method. The motivation and its spec are in this CSR: > > https://bugs.openjdk.java.net/browse/JDK-8254629 > > Naoto
Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 18 additional commits since the last revision: - Merge branch 'master' into dayperiod - Re-worded the spec of appendDayPeriodText, refactored calculation of minute-of-day. - Addressed the following comments: - https://github.com/openjdk/jdk/pull/938#discussion_r522185469 - https://github.com/openjdk/jdk/pull/938#discussion_r522187931 - https://github.com/openjdk/jdk/pull/938#discussion_r522203757 - https://github.com/openjdk/jdk/pull/938#discussion_r522211444 - https://github.com/openjdk/jdk/pull/938#discussion_r522244221 - https://github.com/openjdk/jdk/pull/938#discussion_r522262379 - https://github.com/openjdk/jdk/pull/938#discussion_r522266836 - Added a test case for user defined temporal field resolution with day period. - Clarified 24:00 for "midnight" type in the spec. Some clean up. - Addressing https://github.com/openjdk/jdk/pull/938#discussion_r519061476 - Fixed a comment. - Addressed the following comments: - https://github.com/openjdk/jdk/pull/938#discussion_r518431077 - https://github.com/openjdk/jdk/pull/938#discussion_r518616570 - https://github.com/openjdk/jdk/pull/938#discussion_r518439782 - Fixed typo/grammatical error. - Merge branch 'master' into dayperiod - ... and 8 more: https://git.openjdk.java.net/jdk/compare/0278aec9...e5db226c ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/938/files - new: https://git.openjdk.java.net/jdk/pull/938/files/1aa3134f..e5db226c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=938&range=14 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=938&range=13-14 Stats: 74639 lines in 1037 files changed: 41843 ins; 21966 del; 10830 mod Patch: https://git.openjdk.java.net/jdk/pull/938.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/938/head:pull/938 PR: https://git.openjdk.java.net/jdk/pull/938
