Re: RFR: 8251495: Clarify DOM documentation

2020-09-10 Thread Joe Wang
On Thu, 10 Sep 2020 16:16:57 GMT, Joe Wang wrote: >> Marked as reviewed by alanb (Reviewer). > > Remove the implNote from the package description added by JDK-8249643. > The implementation's deviation from the specification was actually wrong. > It incorrectly identified characters from #x1

Re: RFR: 8251495: Clarify DOM documentation

2020-09-10 Thread Joe Wang
On Thu, 10 Sep 2020 05:45:59 GMT, Alan Bateman wrote: >> Revert changes made by JDK-8249643, removing the implNote. > > Marked as reviewed by alanb (Reviewer). Remove the implNote from the package description added by JDK-8249643. The implementation's deviation from the specification was

Re: RFR: 8251495: Clarify DOM documentation

2020-09-09 Thread Alan Bateman
On Wed, 9 Sep 2020 22:56:14 GMT, Joe Wang wrote: > Revert changes made by JDK-8249643, removing the implNote. Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/100

Re: RFR: 8251495: Clarify DOM documentation

2020-09-09 Thread Naoto Sato
On Wed, 9 Sep 2020 22:56:14 GMT, Joe Wang wrote: > Revert changes made by JDK-8249643, removing the implNote. Looks good. - Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/100

Re: RFR: 8251495: Clarify DOM documentation

2020-09-09 Thread Stuart Marks
On Wed, 9 Sep 2020 22:56:14 GMT, Joe Wang wrote: > Revert changes made by JDK-8249643, removing the implNote. Marked as reviewed by smarks (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/100

Re: RFR: 8251495: Clarify DOM documentation

2020-09-09 Thread Joe Wang
On Wed, 9 Sep 2020 23:15:58 GMT, Lance Andersen wrote: >> Revert changes made by JDK-8249643, removing the implNote. > > Based on the spec review and follow-on discussions, this change makes sense An implNote was added to the DOM's package description in an attempt to document the JDK

Re: RFR: 8251495: Clarify DOM documentation

2020-09-09 Thread Lance Andersen
On Wed, 9 Sep 2020 22:56:14 GMT, Joe Wang wrote: > Revert changes made by JDK-8249643, removing the implNote. Based on the spec review and follow-on discussions, this change makes sense - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/100

RFR: 8251495: Clarify DOM documentation

2020-09-09 Thread Joe Wang
Revert changes made by JDK-8249643, removing the implNote. - Commit messages: - 8251495: Clarify DOM documentation Changes: https://git.openjdk.java.net/jdk/pull/100/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=100=00 Issue: