Re: RFR: 8251989: Hex formatting and parsing utility [v6]

2020-10-21 Thread Marcono1234
On Tue, 20 Oct 2020 14:37:01 GMT, Roger Riggs wrote: >> src/java.base/share/classes/java/util/HexFormat.java line 127: >> >>> 125: * >>> 126: * @implSpec >>> 127: * This class is immutable and thread-safe. >> >> I'm curious why this is an implSpec, and not just a normative statement? >>

Re: RFR: 8251989: Hex formatting and parsing utility [v6]

2020-10-20 Thread Daniel Fuchs
On Mon, 19 Oct 2020 22:52:31 GMT, Roger Riggs wrote: >> java.util.HexFormat utility: >> >> - Format and parse hexadecimal strings, with parameters for delimiter, >> prefix, suffix and upper/lowercase >> - Static factories and builder methods to create HexFormat copies with >> modified

Re: RFR: 8251989: Hex formatting and parsing utility [v6]

2020-10-20 Thread Roger Riggs
On Tue, 20 Oct 2020 10:26:59 GMT, Chris Hegarty wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct length of StringBuilder in formatHex; >> Correct bug in formatHex(char[], 2, 3) and add test for subranges

Re: RFR: 8251989: Hex formatting and parsing utility [v6]

2020-10-20 Thread Roger Riggs
On Tue, 20 Oct 2020 09:44:51 GMT, Chris Hegarty wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct length of StringBuilder in formatHex; >> Correct bug in formatHex(char[], 2, 3) and add test for subranges

Re: RFR: 8251989: Hex formatting and parsing utility [v6]

2020-10-20 Thread Roger Riggs
On Tue, 20 Oct 2020 09:37:23 GMT, Chris Hegarty wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct length of StringBuilder in formatHex; >> Correct bug in formatHex(char[], 2, 3) and add test for subranges

Re: RFR: 8251989: Hex formatting and parsing utility [v6]

2020-10-20 Thread Chris Hegarty
On Mon, 12 Oct 2020 22:17:58 GMT, Marcono1234 wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct length of StringBuilder in formatHex; >> Correct bug in formatHex(char[], 2, 3) and add test for subranges of

Re: RFR: 8251989: Hex formatting and parsing utility [v6]

2020-10-20 Thread Chris Hegarty
On Mon, 19 Oct 2020 22:52:31 GMT, Roger Riggs wrote: >> java.util.HexFormat utility: >> >> - Format and parse hexadecimal strings, with parameters for delimiter, >> prefix, suffix and upper/lowercase >> - Static factories and builder methods to create HexFormat copies with >> modified

Re: RFR: 8251989: Hex formatting and parsing utility [v6]

2020-10-19 Thread Roger Riggs
> java.util.HexFormat utility: > > - Format and parse hexadecimal strings, with parameters for delimiter, > prefix, suffix and upper/lowercase > - Static factories and builder methods to create HexFormat copies with > modified parameters. > - Consistent naming of methods for conversion of