Re: RFR: 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset state variables [v2]

2022-03-30 Thread Naoto Sato
On Wed, 30 Mar 2022 00:46:49 GMT, Joe Wang wrote: >> Resets state of a Catalog instance on each matching call so that it can be >> reused. Adjusts CatalogResolver's resolve routine so that it continues to >> observes the PREFER feature in a resolution process. Without the adjustment, >>

Re: RFR: 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset state variables [v2]

2022-03-29 Thread Joe Wang
On Tue, 29 Mar 2022 21:41:52 GMT, Naoto Sato wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove variable, check instance instead. > > src/java.xml/share/classes/javax/xml/catalog/GroupEntry.java line 44: > >> 42:

Re: RFR: 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset state variables [v2]

2022-03-29 Thread Joe Wang
> Resets state of a Catalog instance on each matching call so that it can be > reused. Adjusts CatalogResolver's resolve routine so that it continues to > observes the PREFER feature in a resolution process. Without the adjustment, > PreferFeatureTest would fail. > > Mach5 XML tests passed: >

Re: RFR: 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset state variables

2022-03-29 Thread Naoto Sato
On Tue, 29 Mar 2022 16:39:50 GMT, Joe Wang wrote: > Resets state of a Catalog instance on each matching call so that it can be > reused. Adjusts CatalogResolver's resolve routine so that it continues to > observes the PREFER feature in a resolution process. Without the adjustment, >

Re: RFR: 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset state variables

2022-03-29 Thread Lance Andersen
On Tue, 29 Mar 2022 16:39:50 GMT, Joe Wang wrote: > Resets state of a Catalog instance on each matching call so that it can be > reused. Adjusts CatalogResolver's resolve routine so that it continues to > observes the PREFER feature in a resolution process. Without the adjustment, >

RFR: 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset state variables

2022-03-29 Thread Joe Wang
Resets state of a Catalog instance on each matching call so that it can be reused. Adjusts CatalogResolver's resolve routine so that it continues to observes the PREFER feature in a resolution process. Without the adjustment, PreferFeatureTest would fail. Mach5 XML tests passed: