On Mon, 19 Oct 2020 11:24:45 GMT, Jorn Vernee wrote:
>> I looked through some Hotspot runtime code and that looks ok. I saw a
>> couple of strange things on my way through the code. See comments.
>
> Hi David, this code somewhat predates me, so I initially kept the JVM_ENTRY
> since that was
On Fri, 16 Oct 2020 11:12:01 GMT, Jorn Vernee wrote:
>> src/hotspot/cpu/x86/foreign_globals_x86.cpp line 56:
>>
>>> 54: }
>>> 55:
>>> 56: const ABIDescriptor parseABIDescriptor(JNIEnv* env, jobject jabi) {
>>
>> I don't know if you care about performance but of these env->calls
>> transition
On Thu, 15 Oct 2020 23:15:07 GMT, Coleen Phillimore wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Re-add file erroneously deleted (detected as rename)
>
> I looked through some Hotspot runtime code and
Hi Jorn,
I'm not reviewing this but this exchange caught my attention ...
On 16/10/2020 9:15 pm, Jorn Vernee wrote:
On Thu, 15 Oct 2020 22:42:49 GMT, Coleen Phillimore wrote:
Maurizio Cimadamore has updated the pull request incrementally with one
additional commit since the last revision:
On Thu, 15 Oct 2020 22:42:49 GMT, Coleen Phillimore wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Re-add file erroneously deleted (detected as rename)
>
> src/hotspot/cpu/x86/foreign_globals_x86.cpp line
On Thu, 15 Oct 2020 22:52:14 GMT, Coleen Phillimore wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Re-add file erroneously deleted (detected as rename)
>
> src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp line
On Thu, 15 Oct 2020 22:44:54 GMT, Coleen Phillimore wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Re-add file erroneously deleted (detected as rename)
>
> src/hotspot/cpu/x86/foreign_globals_x86.hpp line
On Thu, 15 Oct 2020 22:39:50 GMT, Coleen Phillimore wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Re-add file erroneously deleted (detected as rename)
>
> src/hotspot/cpu/x86/foreign_globals_x86.cpp line
On Thu, 15 Oct 2020 17:08:28 GMT, Maurizio Cimadamore
wrote:
>> This patch contains the changes associated with the first incubation round
>> of the foreign linker access API incubation
>> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
>> access support (see JEP 393
> This patch contains the changes associated with the first incubation round of
> the foreign linker access API incubation
> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
> access support (see JEP 393 [2] and
> associated pull request [3]).
> The main goal of this API
10 matches
Mail list logo
