Re: RFR: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines

2021-01-28 Thread Severin Gehwolf
On Thu, 28 Jan 2021 17:19:53 GMT, Poonam Bajaj wrote: > > > I'm curious: What config is this to actually trigger the NPE? How does > > > `/proc/self/mountinfo`, `/proc/self/cgroup` and `/proc/cgroups` look like? > > > > > > > > I'm curious: What config is this to actually trigger the NPE? How

Re: RFR: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines

2021-01-28 Thread Poonam Bajaj
On Thu, 28 Jan 2021 16:00:36 GMT, Severin Gehwolf wrote: > > I'm curious: What config is this to actually trigger the NPE? How does > > `/proc/self/mountinfo`, `/proc/self/cgroup` and `/proc/cgroups` look like? > > > > I'm curious: What config is this to actually trigger the NPE? How does > >

Re: RFR: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines

2021-01-28 Thread Severin Gehwolf
On Thu, 28 Jan 2021 15:01:11 GMT, Poonam Bajaj wrote: >> I'm curious: What config is this to actually trigger the NPE? How does >> `/proc/self/mountinfo`, `/proc/self/cgroup` and `/proc/cgroups` look like? > >> I'm curious: What config is this to actually trigger the NPE? How does >>

Re: RFR: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines

2021-01-28 Thread Poonam Bajaj
On Thu, 28 Jan 2021 14:36:36 GMT, Severin Gehwolf wrote: > I'm curious: What config is this to actually trigger the NPE? How does > `/proc/self/mountinfo`, `/proc/self/cgroup` and `/proc/cgroups` look like? I don't have access to the config. The issue was reported by a customer. -

Re: RFR: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines

2021-01-28 Thread Harold Seigel
On Wed, 27 Jan 2021 21:10:16 GMT, Poonam Bajaj wrote: > Please review this simple change that adds null checks for memory in > CgroupV1Subsystem.java. > > Problem: After the backport of JDK-8250984, there are places where > memory.isSwapEnabled() is called. For example: > > public long

Re: RFR: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines

2021-01-28 Thread Severin Gehwolf
On Wed, 27 Jan 2021 21:10:16 GMT, Poonam Bajaj wrote: > Please review this simple change that adds null checks for memory in > CgroupV1Subsystem.java. > > Problem: After the backport of JDK-8250984, there are places where > memory.isSwapEnabled() is called. For example: > > public long

RFR: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines

2021-01-27 Thread Poonam Bajaj
Please review this simple change that adds null checks for memory in CgroupV1Subsystem.java. Problem: After the backport of JDK-8250984, there are places where memory.isSwapEnabled() is called. For example: public long getMemoryAndSwapFailCount() { if (!memory.isSwapEnabled()) {