On Fri, 22 Jan 2021 18:16:52 GMT, Daniel Fuchs wrote:
>> Alexey Bakhtin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright year
>
> LGTM. Thanks for taking this on!
I will sponsor this!
-
PR:
On Fri, 22 Jan 2021 14:42:10 GMT, Alexey Bakhtin wrote:
>> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
>> Extension.
>> Test from the bug report and jtreg javax/naming tests are passed.
>
> Alexey Bakhtin has updated the pull request incrementally with one
On Fri, 22 Jan 2021 14:42:10 GMT, Alexey Bakhtin wrote:
>> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
>> Extension.
>> Test from the bug report and jtreg javax/naming tests are passed.
>
> Alexey Bakhtin has updated the pull request incrementally with one
> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
> Extension.
> Test from the bug report and jtreg javax/naming tests are passed.
Alexey Bakhtin has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year
On Thu, 21 Jan 2021 19:57:04 GMT, Alexey Bakhtin wrote:
>> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
>> Extension.
>> Test from the bug report and jtreg javax/naming tests are passed.
>
> Alexey Bakhtin has updated the pull request incrementally with one
On Thu, 21 Jan 2021 18:19:10 GMT, Aleksei Efimov wrote:
>> Alexey Bakhtin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> separate tlsHandshakeCompleted for every StartTLS connection
>
>
> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
> Extension.
> Test from the bug report and jtreg javax/naming tests are passed.
Alexey Bakhtin has updated the pull request incrementally with one additional
commit since the last revision:
Add comments and
On Thu, 21 Jan 2021 13:13:38 GMT, Alexey Bakhtin wrote:
>> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
>> Extension.
>> Test from the bug report and jtreg javax/naming tests are passed.
>
> Alexey Bakhtin has updated the pull request incrementally with one
On Wed, 20 Jan 2021 15:54:41 GMT, Daniel Fuchs wrote:
>> New ChannelBinding Data will be recreated for every TLS connection and
>> provided to SASL Client in the new environment properties set (cloned from
>> the original).
>> LdapSasl.java lines 133 - 136:
>>
> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
> Extension.
> Test from the bug report and jtreg javax/naming tests are passed.
Alexey Bakhtin has updated the pull request incrementally with one additional
commit since the last revision:
separate
On Wed, 20 Jan 2021 15:34:24 GMT, Alexey Bakhtin wrote:
> New ChannelBinding Data will be recreated for every TLS connection and
> provided to SASL Client in the new environment properties set (cloned from
> the original).
> LdapSasl.java lines 133 - 136:
>
> ```
>
On Wed, 20 Jan 2021 15:08:56 GMT, Aleksei Efimov wrote:
>> That look reasonable to me. But what would happen if at some point after
>> performing some LDAP operations, you called StartTLSResponse::close and then
>> after some more time you tried to again create a StartTLSRequest on the same
On Wed, 20 Jan 2021 14:41:26 GMT, Daniel Fuchs wrote:
>> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
>> Extension.
>> Test from the bug report and jtreg javax/naming tests are passed.
>
> That look reasonable to me. But what would happen if at some point after
On Thu, 14 Jan 2021 19:28:27 GMT, Alexey Bakhtin wrote:
> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
> Extension.
> Test from the bug report and jtreg javax/naming tests are passed.
That look reasonable to me. But what would happen if at some point after
On Wed, 20 Jan 2021 14:01:45 GMT, Sean Mullan wrote:
>> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
>> Extension.
>> Test from the bug report and jtreg javax/naming tests are passed.
>
> Marked as reviewed by mullan (Reviewer).
Sean, Thank you for review
On Thu, 14 Jan 2021 19:28:27 GMT, Alexey Bakhtin wrote:
> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
> Extension.
> Test from the bug report and jtreg javax/naming tests are passed.
Marked as reviewed by mullan (Reviewer).
-
PR:
On Wed, 20 Jan 2021 07:21:22 GMT, Alexey Bakhtin wrote:
> Unfortunately, I can not find any LDAP StartTLS Extended Operation regression
> tests. security/infra area contains RevocationChecker tests. They can not be
> used for this scenario.
Ok, please add a noreg-hard label to the bug.
On Tue, 19 Jan 2021 20:24:21 GMT, Sean Mullan wrote:
>> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
>> Extension.
>> Test from the bug report and jtreg javax/naming tests are passed.
>
> Can you add a test for this or is it too hard? There are existing tests for
On Thu, 14 Jan 2021 19:28:27 GMT, Alexey Bakhtin wrote:
> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
> Extension.
> Test from the bug report and jtreg javax/naming tests are passed.
Can you add a test for this or is it too hard? There are existing tests for
Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
Extension.
Test from the bug report and jtreg javax/naming tests are passed.
-
Commit messages:
- 8259707: LDAP channel binding does not work with StartTLS extension
Changes:
20 matches
Mail list logo