Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension [v4]

2021-01-22 Thread Daniel Fuchs
On Fri, 22 Jan 2021 18:16:52 GMT, Daniel Fuchs wrote: >> Alexey Bakhtin has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update copyright year > > LGTM. Thanks for taking this on! I will sponsor this! - PR:

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension [v4]

2021-01-22 Thread Daniel Fuchs
On Fri, 22 Jan 2021 14:42:10 GMT, Alexey Bakhtin wrote: >> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS >> Extension. >> Test from the bug report and jtreg javax/naming tests are passed. > > Alexey Bakhtin has updated the pull request incrementally with one

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension [v4]

2021-01-22 Thread Aleksei Efimov
On Fri, 22 Jan 2021 14:42:10 GMT, Alexey Bakhtin wrote: >> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS >> Extension. >> Test from the bug report and jtreg javax/naming tests are passed. > > Alexey Bakhtin has updated the pull request incrementally with one

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension [v4]

2021-01-22 Thread Alexey Bakhtin
> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS > Extension. > Test from the bug report and jtreg javax/naming tests are passed. Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: Update copyright year

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension [v3]

2021-01-22 Thread Aleksei Efimov
On Thu, 21 Jan 2021 19:57:04 GMT, Alexey Bakhtin wrote: >> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS >> Extension. >> Test from the bug report and jtreg javax/naming tests are passed. > > Alexey Bakhtin has updated the pull request incrementally with one

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension [v2]

2021-01-21 Thread Alexey Bakhtin
On Thu, 21 Jan 2021 18:19:10 GMT, Aleksei Efimov wrote: >> Alexey Bakhtin has updated the pull request incrementally with one >> additional commit since the last revision: >> >> separate tlsHandshakeCompleted for every StartTLS connection > >

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension [v3]

2021-01-21 Thread Alexey Bakhtin
> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS > Extension. > Test from the bug report and jtreg javax/naming tests are passed. Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: Add comments and

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension [v2]

2021-01-21 Thread Aleksei Efimov
On Thu, 21 Jan 2021 13:13:38 GMT, Alexey Bakhtin wrote: >> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS >> Extension. >> Test from the bug report and jtreg javax/naming tests are passed. > > Alexey Bakhtin has updated the pull request incrementally with one

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension [v2]

2021-01-21 Thread Alexey Bakhtin
On Wed, 20 Jan 2021 15:54:41 GMT, Daniel Fuchs wrote: >> New ChannelBinding Data will be recreated for every TLS connection and >> provided to SASL Client in the new environment properties set (cloned from >> the original). >> LdapSasl.java lines 133 - 136: >>

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension [v2]

2021-01-21 Thread Alexey Bakhtin
> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS > Extension. > Test from the bug report and jtreg javax/naming tests are passed. Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: separate

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension

2021-01-20 Thread Daniel Fuchs
On Wed, 20 Jan 2021 15:34:24 GMT, Alexey Bakhtin wrote: > New ChannelBinding Data will be recreated for every TLS connection and > provided to SASL Client in the new environment properties set (cloned from > the original). > LdapSasl.java lines 133 - 136: > > ``` >

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension

2021-01-20 Thread Alexey Bakhtin
On Wed, 20 Jan 2021 15:08:56 GMT, Aleksei Efimov wrote: >> That look reasonable to me. But what would happen if at some point after >> performing some LDAP operations, you called StartTLSResponse::close and then >> after some more time you tried to again create a StartTLSRequest on the same

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension

2021-01-20 Thread Aleksei Efimov
On Wed, 20 Jan 2021 14:41:26 GMT, Daniel Fuchs wrote: >> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS >> Extension. >> Test from the bug report and jtreg javax/naming tests are passed. > > That look reasonable to me. But what would happen if at some point after

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension

2021-01-20 Thread Daniel Fuchs
On Thu, 14 Jan 2021 19:28:27 GMT, Alexey Bakhtin wrote: > Please review a small patch to enable LDAP TLS Channel Binding with StartTLS > Extension. > Test from the bug report and jtreg javax/naming tests are passed. That look reasonable to me. But what would happen if at some point after

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension

2021-01-20 Thread Alexey Bakhtin
On Wed, 20 Jan 2021 14:01:45 GMT, Sean Mullan wrote: >> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS >> Extension. >> Test from the bug report and jtreg javax/naming tests are passed. > > Marked as reviewed by mullan (Reviewer). Sean, Thank you for review

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension

2021-01-20 Thread Sean Mullan
On Thu, 14 Jan 2021 19:28:27 GMT, Alexey Bakhtin wrote: > Please review a small patch to enable LDAP TLS Channel Binding with StartTLS > Extension. > Test from the bug report and jtreg javax/naming tests are passed. Marked as reviewed by mullan (Reviewer). - PR:

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension

2021-01-20 Thread Sean Mullan
On Wed, 20 Jan 2021 07:21:22 GMT, Alexey Bakhtin wrote: > Unfortunately, I can not find any LDAP StartTLS Extended Operation regression > tests. security/infra area contains RevocationChecker tests. They can not be > used for this scenario. Ok, please add a noreg-hard label to the bug.

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension

2021-01-19 Thread Alexey Bakhtin
On Tue, 19 Jan 2021 20:24:21 GMT, Sean Mullan wrote: >> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS >> Extension. >> Test from the bug report and jtreg javax/naming tests are passed. > > Can you add a test for this or is it too hard? There are existing tests for

Re: RFR: 8259707: LDAP channel binding does not work with StartTLS extension

2021-01-19 Thread Sean Mullan
On Thu, 14 Jan 2021 19:28:27 GMT, Alexey Bakhtin wrote: > Please review a small patch to enable LDAP TLS Channel Binding with StartTLS > Extension. > Test from the bug report and jtreg javax/naming tests are passed. Can you add a test for this or is it too hard? There are existing tests for

RFR: 8259707: LDAP channel binding does not work with StartTLS extension

2021-01-14 Thread Alexey Bakhtin
Please review a small patch to enable LDAP TLS Channel Binding with StartTLS Extension. Test from the bug report and jtreg javax/naming tests are passed. - Commit messages: - 8259707: LDAP channel binding does not work with StartTLS extension Changes: