Re: RFR: 8261728: SimpleDateFormat should link to DateTimeFormatter [v2]

2021-02-18 Thread Roger Riggs 
On Wed, 17 Feb 2021 20:21:57 GMT, Naoto Sato  wrote:

>> Please review this simple doc fix. A CSR will be filed accordingly.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Made the additional text an @apiNote

Marked as reviewed by rriggs (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/2616

Re: RFR: 8261728: SimpleDateFormat should link to DateTimeFormatter [v2]

2021-02-17 Thread Iris Clark 
On Wed, 17 Feb 2021 20:21:57 GMT, Naoto Sato  wrote:

>> Please review this simple doc fix. A CSR will be filed accordingly.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Made the additional text an @apiNote

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/2616

Re: RFR: 8261728: SimpleDateFormat should link to DateTimeFormatter [v2]

2021-02-17 Thread Naoto Sato 
On Wed, 17 Feb 2021 20:04:33 GMT, Lance Andersen  wrote:

>> Naoto Sato has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Made the additional text an @apiNote
>
> Hi Naoto,
> 
> Looks good.  
> 
> Any thoughts to making the new wording stick out more perhaps via a something 
> like  "Note: Consider" and bolding "Note:" 
> 
> 
> Not sure if it is @apiNote worthy but I guess that is an option also?

> Not sure if it is @APinote worthy but I guess that is an option also?

Good point. Modified.

-

PR: https://git.openjdk.java.net/jdk/pull/2616

Re: RFR: 8261728: SimpleDateFormat should link to DateTimeFormatter [v2]

2021-02-17 Thread Lance Andersen 
On Wed, 17 Feb 2021 20:18:56 GMT, Naoto Sato  wrote:

>> Please review this simple doc fix. A CSR will be filed accordingly.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Made the additional text an @apiNote

Marked as reviewed by lancea (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/2616

Re: RFR: 8261728: SimpleDateFormat should link to DateTimeFormatter [v2]

2021-02-17 Thread Brian Burkhalter 
On Wed, 17 Feb 2021 20:18:56 GMT, Naoto Sato  wrote:

>> Please review this simple doc fix. A CSR will be filed accordingly.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Made the additional text an @apiNote

Marked as reviewed by bpb (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/2616

Re: RFR: 8261728: SimpleDateFormat should link to DateTimeFormatter [v2]

2021-02-17 Thread Naoto Sato 
> Please review this simple doc fix. A CSR will be filed accordingly.

Naoto Sato has updated the pull request incrementally with one additional 
commit since the last revision:

  Made the additional text an @apiNote

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2616/files
  - new: https://git.openjdk.java.net/jdk/pull/2616/files/d840b562..c93badb4

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=2616=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=2616=00-01

  Stats: 4 lines in 2 files changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2616.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2616/head:pull/2616

PR: https://git.openjdk.java.net/jdk/pull/2616