On Tue, 13 Apr 2021 19:30:53 GMT, Joe Wang wrote:
>> Although the code path is different, the logic to determine the encoding is
>> not changed, as `sun.stdout/err.encoding` are only set if the VM is invoked
>> from a terminal (in fact, there's a bug where they aren't set even in a
>>
On Tue, 13 Apr 2021 18:24:55 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/lang/System.java line 2020:
>>
>>> 2018: setIn0(new BufferedInputStream(fdIn));
>>> 2019: setOut0(newPrintStream(fdOut, cs));
>>> 2020: setErr0(newPrintStream(fdErr, cs));
>>
>> It
On Tue, 13 Apr 2021 13:04:17 GMT, Alan Bateman wrote:
> 1. I think method name "charset()" is too short. It's not called frequently.
> This method name should explain functionality.
As for this one, I am open for suggestions. I thought `consoel()` was concise,
and analogous to
On Tue, 13 Apr 2021 02:34:15 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reverted PrintStream changes
>
> src/java.base/share/classes/java/lang/System.java line 2020:
>
>> 2018: setIn0(new
On Tue, 13 Apr 2021 12:54:51 GMT, Ichiroh Takiguchi
wrote:
> 1. I think method name "charset()" is too short. It's not called frequently.
> This method name should explain functionality.
> 2. Sometimes stderr may be redirected to stdout by shell. Why do we need to
> set different encodings
On Mon, 12 Apr 2021 23:01:24 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been
On Mon, 12 Apr 2021 23:01:24 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
>
