On Tue, 1 Jun 2021 17:43:45 GMT, Igor Veresov wrote:
>> Thank you @veresov!
>>
>> I'm glad to have more comments from hotspot-compiler group.
>>
>> Later, I'd like to integrate it if there are no more comments/objections.
>>
>> Thanks!
>> Yang
>
> @kelthuzadx Sorry about the delay. Could
On Tue, 25 May 2021 02:44:41 GMT, Yi Yang wrote:
>> Looks like now the test fails in the pre-submit tests?
>
> Thank you @veresov!
>
> I'm glad to have more comments from hotspot-compiler group.
>
> Later, I'd like to integrate it if there are no more comments/objections.
>
> Thanks!
> Yang
On Fri, 30 Apr 2021 19:20:54 GMT, Igor Veresov wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> better check1-4
>
> Looks like now the test fails in the pre-submit tests?
Thank you @veresov!
I'm glad to have more
On Fri, 30 Apr 2021 19:20:54 GMT, Igor Veresov wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> better check1-4
>
> Looks like now the test fails in the pre-submit tests?
Hi @veresov, may I ask your help to review this
On Sat, 8 May 2021 05:32:00 GMT, Yi Yang wrote:
> It seems that Object.checkIndex can not meet our needs because it implicitly
> passes null to Preconditions.checkIndex, but we want to customize exception
> messages, so we might add extra APIs in Objects while doing the replacement.
>
It
On Fri, 30 Apr 2021 19:20:54 GMT, Igor Veresov wrote:
> Looks like now the test fails in the pre-submit tests?
Hi Igor,
Can you take a look at the latest version? Now it passes all pre-submit tests.
Best Regards,
Yang
-
PR: https://git.openjdk.java.net/jdk/pull/3615
On Fri, 30 Apr 2021 17:30:33 GMT, Paul Sandoz wrote:
> It was my hope this would eventually happen when we added
> `Objects.checkIndex` and the underlying intrinsic. Very good!
Hi Paul,
Thank you for noticing this PR.
> It was my hope this would eventually happen when we added
>
On Fri, 30 Apr 2021 02:19:30 GMT, Yi Yang wrote:
>> The JDK codebase re-created many variants of checkIndex(`grep -I -r
>> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
>> annotated with @IntrinsicCandidate and it only has a corresponding C1
>> intrinsic version.
On Fri, 30 Apr 2021 02:19:30 GMT, Yi Yang wrote:
>> The JDK codebase re-created many variants of checkIndex(`grep -I -r
>> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
>> annotated with @IntrinsicCandidate and it only has a corresponding C1
>> intrinsic version.
On Fri, 30 Apr 2021 02:19:30 GMT, Yi Yang wrote:
>> The JDK codebase re-created many variants of checkIndex(`grep -I -r
>> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
>> annotated with @IntrinsicCandidate and it only has a corresponding C1
>> intrinsic version.
> The JDK codebase re-created many variants of checkIndex(`grep -I -r
> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
> annotated with @IntrinsicCandidate and it only has a corresponding C1
> intrinsic version.
>
> In fact, there is an utility method
>
11 matches
Mail list logo
