Re: RFR: 8266078: Reader.read(CharBuffer) advances Reader position for read-only Charbuffers [v3]
On Wed, 28 Apr 2021 15:29:20 GMT, Brian Burkhalter wrote: >> Please consider this request to modify `Reader.read(CharBuffer)` to check >> whether the buffer is read-only before reading any characters from the >> character stream. This can happen now if the buffer is read-only. Character >> are first read thereby advancing the stream before an attempt is made to put >> them in the `CharBuffer` thus incorrectly advancing the stream position. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8266078: Remove confusing comment Marked as reviewed by chegar (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3725
Re: RFR: 8266078: Reader.read(CharBuffer) advances Reader position for read-only Charbuffers [v3]
> Please consider this request to modify `Reader.read(CharBuffer)` to check > whether the buffer is read-only before reading any characters from the > character stream. This can happen now if the buffer is read-only. Character > are first read thereby advancing the stream before an attempt is made to put > them in the `CharBuffer` thus incorrectly advancing the stream position. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8266078: Remove confusing comment - Changes: - all: https://git.openjdk.java.net/jdk/pull/3725/files - new: https://git.openjdk.java.net/jdk/pull/3725/files/4a899b26..8935981a Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3725&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3725&range=01-02 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/3725.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3725/head:pull/3725 PR: https://git.openjdk.java.net/jdk/pull/3725