On Tue, 29 Jun 2021 00:07:41 GMT, Sean Coffey wrote:
>> Sufficient permissions missing if this code was ever to run with
>> SecurityManager.
>>
>> Cleanest approach appears to be use of InnocuousThread to create the
>> cleaner/poller threads.
>> Test case coverage extended to cover the
Hi Valerie,
many thanks for the thorough review. I've taken all your feedback on
board with the latest push. Some of the test anomalies were a result of
previous iterations of test edits I had been making.
Regarding the extra edits in
"src/java.base/share/lib/security/default.policy", I had
> Sufficient permissions missing if this code was ever to run with
> SecurityManager.
>
> Cleanest approach appears to be use of InnocuousThread to create the
> cleaner/poller threads.
> Test case coverage extended to cover the SecurityManager scenario.
>
> Reviewer request: @valeriepeng
On Tue, 22 Jun 2021 20:08:03 GMT, Sean Coffey wrote:
>> Sufficient permissions missing if this code was ever to run with
>> SecurityManager.
>>
>> Cleanest approach appears to be use of InnocuousThread to create the
>> cleaner/poller threads.
>> Test case coverage extended to cover the
On Fri, 25 Jun 2021 19:39:22 GMT, Valerie Peng wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move TokenPoller to Runnable
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java line
> 952:
On Tue, 22 Jun 2021 20:08:03 GMT, Sean Coffey wrote:
>> Sufficient permissions missing if this code was ever to run with
>> SecurityManager.
>>
>> Cleanest approach appears to be use of InnocuousThread to create the
>> cleaner/poller threads.
>> Test case coverage extended to cover the
Thanks Seán,
A good explanation. :)
Solaris was a very good platform for exposing and debugging race
conditions, of course we have very good static analysis now.
Regards,
Peter.
On 23/06/2021 5:10 pm, Seán Coffey wrote:
Thank for the feedback Peter. Comments inline.
On 22/06/2021 22:40,
Thank for the feedback Peter. Comments inline.
On 22/06/2021 22:40, Peter Firmstone wrote:
Was ever to run with SecurityManager?
I found the issue while porting to jdk8u where Solaris uses a
configuration file with the SunPKCS11 Provider by default - We have
tests to register Providers while
On Tue, 22 Jun 2021 20:08:03 GMT, Sean Coffey wrote:
>> Sufficient permissions missing if this code was ever to run with
>> SecurityManager.
>>
>> Cleanest approach appears to be use of InnocuousThread to create the
>> cleaner/poller threads.
>> Test case coverage extended to cover the
> Sufficient permissions missing if this code was ever to run with
> SecurityManager.
>
> Cleanest approach appears to be use of InnocuousThread to create the
> cleaner/poller threads.
> Test case coverage extended to cover the SecurityManager scenario.
>
> Reviewer request: @valeriepeng
Sufficient permissions missing if this code was ever to run with
SecurityManager.
Cleanest approach appears to be use of InnocuousThread to create the
cleaner/poller threads.
Test case coverage extended to cover the SecurityManager scenario.
Reviewer request: @valeriepeng
-
On Tue, 22 Jun 2021 12:01:07 GMT, Sean Coffey wrote:
> Sufficient permissions missing if this code was ever to run with
> SecurityManager.
>
> Cleanest approach appears to be use of InnocuousThread to create the
> cleaner/poller threads.
> Test case coverage extended to cover the
Sufficient permissions missing if this code was ever to run with
SecurityManager.
Cleanest approach appears to be use of InnocuousThread to create the
cleaner/poller threads.
Test case coverage extended to cover the SecurityManager scenario.
Reviewer request: @valeriepeng
-
13 matches
Mail list logo
