On Thu, 16 Sep 2021 01:29:41 GMT, wxiang
wrote:
>> wxiang has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> add isEmpty check
>
> I have changed
>
> ENABLE_JAR_INDEX = p != null ? p.equals("true") : false;
>
> to
>
> ENABLE_JAR_INDEX
On Thu, 16 Sep 2021 01:29:41 GMT, wxiang
wrote:
>> wxiang has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> add isEmpty check
>
> I have changed
>
> ENABLE_JAR_INDEX = p != null ? p.equals("true") : false;
>
> to
>
> ENABLE_JAR_INDEX
On Thu, 16 Sep 2021 13:32:08 GMT, wxiang
wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> Currently, there was agreement on dropping the support from the
>> URLClassLoader implementation but it was suggested that it should be
>> disabled for a release or two before
On Thu, 16 Sep 2021 11:08:17 GMT, Alan Bateman wrote:
>> wxiang has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> add isEmpty check
>
> src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 949:
>
>> 947:
> There is a bug for URLClassPath.findResources with JarIndex.
> Currently, there was agreement on dropping the support from the
> URLClassLoader implementation but it was suggested that it should be disabled
> for a release or two before the code is removed.
> A system property can be used to
On Thu, 16 Sep 2021 13:29:09 GMT, wxiang
wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> Currently, there was agreement on dropping the support from the
>> URLClassLoader implementation but it was suggested that it should be
>> disabled for a release or two before
On Thu, 16 Sep 2021 01:29:12 GMT, wxiang
wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> Currently, there was agreement on dropping the support from the
>> URLClassLoader implementation but it was suggested that it should be
>> disabled for a release or two before
On Thu, 16 Sep 2021 01:29:12 GMT, wxiang
wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> Currently, there was agreement on dropping the support from the
>> URLClassLoader implementation but it was suggested that it should be
>> disabled for a release or two before
On Thu, 16 Sep 2021 09:33:44 GMT, wxiang
wrote:
>> Given that there is a precedence in this file:
>>
>>
>> p =
>> props.getProperty("jdk.net.URLClassPath.showIgnoredClassPathEntries");
>> DEBUG_CP_URL_CHECK = p != null ? p.equals("true") || p.isEmpty() :
>> false;
>>
>>
>>
On Thu, 16 Sep 2021 09:15:34 GMT, Daniel Fuchs wrote:
>> I can appreciate that and that is a fair point. I guess where I was
>> coming from was that the property is temporary and has to be explicitly
>> specified so ignoring the value seemed worth raising/discussing.
>>
>> Assuming the
On Wed, 15 Sep 2021 19:41:11 GMT, Lance Andersen wrote:
>> I would dislike it if `-Djdk.net.URLClassPath.enableJarIndex=false` meant
>> true...
>
> I can appreciate that and that is a fair point. I guess where I was coming
> from was that the property is temporary and has to be explicitly
On Thu, 16 Sep 2021 01:29:12 GMT, wxiang
wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> Currently, there was agreement on dropping the support from the
>> URLClassLoader implementation but it was suggested that it should be
>> disabled for a release or two before
On Thu, 16 Sep 2021 01:29:12 GMT, wxiang
wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> Currently, there was agreement on dropping the support from the
>> URLClassLoader implementation but it was suggested that it should be
>> disabled for a release or two before
> There is a bug for URLClassPath.findResources with JarIndex.
> Currently, there was agreement on dropping the support from the
> URLClassLoader implementation but it was suggested that it should be disabled
> for a release or two before the code is removed.
> A system property can be used to
On Wed, 15 Sep 2021 18:59:08 GMT, Daniel Fuchs wrote:
>> I assume the reason for specifically checking for a value of true or an
>> empty string as you envision allowing the property to be explicitly set to
>> false in the future?
>>
>> Otherwise we could just check if the property is
On Wed, 15 Sep 2021 18:29:44 GMT, Lance Andersen wrote:
>>> Maybe this should use the same pattern than the other property above:
>>>
>>> ```
>>> ENABLE_JAR_INDEX = p != null ? p.equals("true") || p.isEmpty() : false;
>>> ```
>>
>> Yes, the intention is that
On Wed, 15 Sep 2021 15:48:55 GMT, Alan Bateman wrote:
>>> Another question is where to document this property. We will obviously need
>>> a CSR and releases notes. I also wonder if it should be promoted into a
>>> networking property - which would make it possible to document it in the
>>>
On Wed, 15 Sep 2021 09:33:10 GMT, wxiang
wrote:
> There is a bug for URLClassPath.findResources with JarIndex.
> Currently, there was agreement on dropping the support from the
> URLClassLoader implementation but it was suggested that it should be disabled
> for a release or two before the
On Wed, 15 Sep 2021 12:09:31 GMT, Alan Bateman wrote:
>> Another question is where to document this property. We will obviously need
>> a CSR and releases notes. I also wonder if it should be promoted into a
>> networking property - which would make it possible to document it in the
>>
On Wed, 15 Sep 2021 12:02:51 GMT, Daniel Fuchs wrote:
> Another question is where to document this property. We will obviously need a
> CSR and releases notes. I also wonder if it should be promoted into a
> networking property - which would make it possible to document it in the
>
On Wed, 15 Sep 2021 09:33:10 GMT, wxiang
wrote:
> There is a bug for URLClassPath.findResources with JarIndex.
> Currently, there was agreement on dropping the support from the
> URLClassLoader implementation but it was suggested that it should be disabled
> for a release or two before the
On Wed, 15 Sep 2021 12:00:07 GMT, Daniel Fuchs wrote:
>> There is a bug for URLClassPath.findResources with JarIndex.
>> Currently, there was agreement on dropping the support from the
>> URLClassLoader implementation but it was suggested that it should be
>> disabled for a release or two
There is a bug for URLClassPath.findResources with JarIndex.
Currently, there was agreement on dropping the support from the URLClassLoader
implementation but it was suggested that it should be disabled for a release or
two before the code is removed.
A system property can be used to re-enable
23 matches
Mail list logo
