Re: RFR: 8276947: Clarify how DateTimeFormatterBuilder.appendFraction handles value ranges

2021-11-11 Thread Claes Redestad
On Wed, 10 Nov 2021 13:57:21 GMT, Claes Redestad  wrote:

> This changes the specification of `DateTimeFormatterBuilder.appendFraction` 
> to more clearly specify that the formatter will throw an exception if you 
> attempt to print a value outside of the value range of the given field. 
> Changes suggested by @jodastephen in #6188.

Thanks Roger and Naoto. CSR has been filed and approved.

-

PR: https://git.openjdk.java.net/jdk/pull/6335


Re: RFR: 8276947: Clarify how DateTimeFormatterBuilder.appendFraction handles value ranges

2021-11-10 Thread Naoto Sato
On Wed, 10 Nov 2021 13:57:21 GMT, Claes Redestad  wrote:

> This changes the specification of `DateTimeFormatterBuilder.appendFraction` 
> to more clearly specify that the formatter will throw an exception if you 
> attempt to print a value outside of the value range of the given field. 
> Changes suggested by @jodastephen in #6188.

Marked as reviewed by naoto (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/6335


Re: RFR: 8276947: Clarify how DateTimeFormatterBuilder.appendFraction handles value ranges

2021-11-10 Thread Roger Riggs
On Wed, 10 Nov 2021 13:57:21 GMT, Claes Redestad  wrote:

> This changes the specification of `DateTimeFormatterBuilder.appendFraction` 
> to more clearly specify that the formatter will throw an exception if you 
> attempt to print a value outside of the value range of the given field. 
> Changes suggested by @jodastephen in #6188.

Marked as reviewed by rriggs (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/6335


RFR: 8276947: Clarify how DateTimeFormatterBuilder.appendFraction handles value ranges

2021-11-10 Thread Claes Redestad
This changes the specification of `DateTimeFormatterBuilder.appendFraction` to 
more clearly specify that the formatter will throw an exception if you attempt 
to print a value outside of the value range of the given field. Changes 
suggested by @jodastephen in #6188.

-

Commit messages:
 - Clarify how DateTimeFormatterBuilder.appendFraction handles value ranges

Changes: https://git.openjdk.java.net/jdk/pull/6335/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6335=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8276947
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6335.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6335/head:pull/6335

PR: https://git.openjdk.java.net/jdk/pull/6335