Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-12-07 Thread Alexey Ivanov
On Tue, 7 Dec 2021 08:16:08 GMT, Сергей Цыпанов wrote: >> src/java.desktop/share/classes/java/awt/geom/Line2D.java line 115: >> >>> 113: */ >>> 114: public double getX1() { >>> 115: return x1; >> >> What do these changes have to do with the subject of the PR ? > >

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-12-07 Thread Сергей Цыпанов
On Mon, 6 Dec 2021 17:48:37 GMT, Phil Race wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8277868: Use Integer.signum() in BasicTableUI > > src/java.desktop/share/classes/sun/java2d/Spans.java line 322: > >>

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-12-07 Thread Сергей Цыпанов
On Mon, 6 Dec 2021 17:46:22 GMT, Phil Race wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8277868: Use Integer.signum() in BasicTableUI > > src/java.desktop/share/classes/java/awt/geom/Line2D.java line 115: >

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-12-06 Thread Phil Race
On Mon, 29 Nov 2021 08:18:47 GMT, Сергей Цыпанов wrote: >> Instead of something like >> >> long x; >> long y; >> return (x < y) ? -1 : ((x == y) ? 0 : 1); >> >> we can use `return Long.compare(x, y);` >> >> All replacements are done with IDE. > > Сергей Цыпанов has updated the pull request

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-11-30 Thread Roger Riggs
On Mon, 29 Nov 2021 08:18:47 GMT, Сергей Цыпанов wrote: >> Instead of something like >> >> long x; >> long y; >> return (x < y) ? -1 : ((x == y) ? 0 : 1); >> >> we can use `return Long.compare(x, y);` >> >> All replacements are done with IDE. > > Сергей Цыпанов has updated the pull request

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-11-29 Thread Сергей Цыпанов
> Instead of something like > > long x; > long y; > return (x < y) ? -1 : ((x == y) ? 0 : 1); > > we can use `return Long.compare(x, y);` > > All replacements are done with IDE. Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-11-29 Thread Сергей Цыпанов
On Sat, 27 Nov 2021 22:50:55 GMT, Michael Bien wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8277868: Use Integer.signum() in BasicTableUI > >