Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code [v3]

2022-01-10 Thread Сергей Цыпанов
> `Executable.getParameterTypes()` creates a copy of underlying array which is > redundant in trusted code when we are sure the action is read-only. Сергей Цыпанов has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: -

Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code [v2]

2022-01-10 Thread Claes Redestad
On Mon, 10 Jan 2022 09:53:56 GMT, Сергей Цыпанов wrote: >> src/java.base/share/classes/java/lang/reflect/Executable.java line 317: >> >>> 315: final boolean realParamData = hasRealParameterData(); >>> 316: final Type[] genericParamTypes = >>> getGenericParameterTypes();

Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code [v2]

2022-01-10 Thread Claes Redestad
On Mon, 10 Jan 2022 10:02:18 GMT, Сергей Цыпанов wrote: >> `Executable.getParameterTypes()` creates a copy of underlying array which is >> redundant in trusted code when we are sure the action is read-only. > > Сергей Цыпанов has updated the pull request incrementally with one additional >

Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code [v2]

2022-01-10 Thread Сергей Цыпанов
> `Executable.getParameterTypes()` creates a copy of underlying array which is > redundant in trusted code when we are sure the action is read-only. Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision: 8278461: Revert Executable

Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code [v2]

2022-01-10 Thread Сергей Цыпанов
On Mon, 10 Jan 2022 09:38:15 GMT, Сергей Цыпанов wrote: >> src/java.base/share/classes/java/lang/reflect/Executable.java line 313: >> >>> 311: // getParameterTypes(). >>> 312: if (!genericInfo) { >>> 313: return getSharedParameterTypes(); >> >> Since this returns

Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code

2022-01-10 Thread Сергей Цыпанов
On Thu, 6 Jan 2022 16:45:09 GMT, Claes Redestad wrote: >> `Executable.getParameterTypes()` creates a copy of underlying array which is >> redundant in trusted code when we are sure the action is read-only. > > src/java.base/share/classes/java/lang/reflect/Executable.java line 317: > >> 315:

Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code

2022-01-10 Thread Сергей Цыпанов
On Thu, 6 Jan 2022 16:38:05 GMT, Claes Redestad wrote: >> `Executable.getParameterTypes()` creates a copy of underlying array which is >> redundant in trusted code when we are sure the action is read-only. > > src/java.base/share/classes/java/lang/reflect/Executable.java line 313: > >> 311:

Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code

2022-01-06 Thread Claes Redestad
On Thu, 9 Dec 2021 11:50:50 GMT, Сергей Цыпанов wrote: > `Executable.getParameterTypes()` creates a copy of underlying array which is > redundant in trusted code when we are sure the action is read-only. Changes requested by redestad (Reviewer).

Re: RFR: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code

2022-01-06 Thread Сергей Цыпанов
On Thu, 9 Dec 2021 11:50:50 GMT, Сергей Цыпанов wrote: > `Executable.getParameterTypes()` creates a copy of underlying array which is > redundant in trusted code when we are sure the action is read-only. Let's wait - PR: https://git.openjdk.java.net/jdk/pull/6782