Re: RFR: 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate [v4]
On Mon, 7 Mar 2022 18:47:17 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/time/chrono/IsoChronology.java line 689:
>>
>>> 687: */
>>> 688: @Override
>>> 689: public boolean isIsoBased() {
>>
>> Is this meant to be 'default'? The CSR indicated adding default methods.
>
> The `default` method has been added to `java.time.chrono.Chronology`
> interface. This is its overridden method implemented in `IsoChronology`
> concrete class.
To make navigation easier, change the @code references to be @links and include
the IsoField name.
I don't think the @implspec is needed, its redundant with @return.
Apply similar changes to the other ISO chronologies javadoc.
-
PR: https://git.openjdk.java.net/jdk/pull/7683
Re: RFR: 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate [v4]
On Mon, 7 Mar 2022 18:20:43 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains five additional commits since
> the last revision:
>
> - Renamed the new method
> - Merge branch 'master' into JDK-8279185
> - Addresses review comments
> - copyright year fix
> - 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate
src/java.base/share/classes/java/time/chrono/IsoChronology.java line 689:
> 687: */
> 688: @Override
> 689: public boolean isIsoBased() {
Is this meant to be 'default'? The CSR indicated adding default methods.
-
PR: https://git.openjdk.java.net/jdk/pull/7683
Re: RFR: 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate [v4]
On Mon, 7 Mar 2022 18:30:28 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Renamed the new method
>> - Merge branch 'master' into JDK-8279185
>> - Addresses review comments
>> - copyright year fix
>> - 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate
>
> src/java.base/share/classes/java/time/chrono/IsoChronology.java line 689:
>
>> 687: */
>> 688: @Override
>> 689: public boolean isIsoBased() {
>
> Is this meant to be 'default'? The CSR indicated adding default methods.
The `default` method has been added to `java.time.chrono.Chronology` interface.
This is its overridden method implemented in `IsoChronology` concrete class.
-
PR: https://git.openjdk.java.net/jdk/pull/7683
Re: RFR: 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate [v4]
> Supporting `IsoFields` temporal fields in chronologies that are similar to > ISO chronology. Corresponding CSR has also been drafted. Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Renamed the new method - Merge branch 'master' into JDK-8279185 - Addresses review comments - copyright year fix - 8279185: Support for IsoFields in JapaneseDate/MinguoDate/ThaiBuddhistDate - Changes: - all: https://git.openjdk.java.net/jdk/pull/7683/files - new: https://git.openjdk.java.net/jdk/pull/7683/files/e0b329d7..530ed40e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7683&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7683&range=02-03 Stats: 12800 lines in 349 files changed: 8488 ins; 2645 del; 1667 mod Patch: https://git.openjdk.java.net/jdk/pull/7683.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7683/head:pull/7683 PR: https://git.openjdk.java.net/jdk/pull/7683
