Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v4]
On Wed, 16 Mar 2022 18:31:55 GMT, Alisen Chung wrote: >> msg drop for jdk19, Mar 9, 2022 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > removed incorrect translation of compiler configuration file LGTM. Thanks for the change. - Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7765
Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v4]
> msg drop for jdk19, Mar 9, 2022 Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: removed incorrect translation of compiler configuration file - Changes: - all: https://git.openjdk.java.net/jdk/pull/7765/files - new: https://git.openjdk.java.net/jdk/pull/7765/files/d5c9b884..715a6ad7 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7765=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7765=02-03 Stats: 2310 lines in 3 files changed: 0 ins; 2310 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/7765.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7765/head:pull/7765 PR: https://git.openjdk.java.net/jdk/pull/7765
Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v3]
On Mon, 14 Mar 2022 20:39:46 GMT, Alisen Chung wrote: >> msg drop for jdk19, Mar 9, 2022 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > removed repeated lines from ROOT bundle in CurrencyNames src/jdk.compiler/share/classes/com/sun/tools/javac/resources/ct_ja.properties line 1: > 1: # The change to this file (moving ct.properties to ct_ja.properties) does look suspicious. Looks like this is not a translation file, but some kind of a configuration for `javac`. If so, it should not be translated (and translation configuration in the closed repository should exclude this file) - PR: https://git.openjdk.java.net/jdk/pull/7765
Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v3]
> msg drop for jdk19, Mar 9, 2022 Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: removed repeated lines from ROOT bundle in CurrencyNames - Changes: - all: https://git.openjdk.java.net/jdk/pull/7765/files - new: https://git.openjdk.java.net/jdk/pull/7765/files/4735722d..d5c9b884 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7765=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7765=01-02 Stats: 675 lines in 3 files changed: 0 ins; 675 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/7765.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7765/head:pull/7765 PR: https://git.openjdk.java.net/jdk/pull/7765
Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote: >> msg drop for jdk19, Mar 9, 2022 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > moved CurrencyNames changes to jdk.localedata Marked as reviewed by kizune (Reviewer). Clientlibs related stuff looks correct. - PR: https://git.openjdk.java.net/jdk/pull/7765
Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]
On Thu, 10 Mar 2022 18:56:41 GMT, Chris Plummer wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> moved CurrencyNames changes to jdk.localedata
>
> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_ja.java
> line 305:
>
>> 303: {"Thread not suspended",
>> "\u30B9\u30EC\u30C3\u30C9\u306F\u4E2D\u65AD\u3057\u3066\u3044\u307E\u305B\u3093"},
>> 304: {"thread group number description name", "{0,number,integer}.
>> {1} {2}"},
>> 305: {"Threadgroup name not specified.",
>> "\u30B9\u30EC\u30C3\u30C9\u30B0\u30EB\u30FC\u30D7\u540D\u304C\u6307\u5B9A\u3055\u308C\u3066\u3044\u307E\u305B\u3093\u3002"},
>
> I'm not sure what happened here. This resource was just removed yesterday as
> part of #7687. It had been around for a long time before that (probably from
> the beginning of this file), so I'm not sure what triggered getting it
> re-added.
The translation was started before the updates to this file. This update can be
done in the next msg drop.
-
PR: https://git.openjdk.java.net/jdk/pull/7765
Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote: >> msg drop for jdk19, Mar 9, 2022 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > moved CurrencyNames changes to jdk.localedata The security related changes look fine, except for the year 2021. - PR: https://git.openjdk.java.net/jdk/pull/7765
Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote: >> msg drop for jdk19, Mar 9, 2022 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > moved CurrencyNames changes to jdk.localedata src/jdk.localedata/share/classes/sun/util/resources/ext/CurrencyNames_de.properties line 63: > 61: # written authorization of the copyright holder. > 62: > 63: ADP=ADP No need for these lines in each localized files, as English bundle contains them. src/jdk.localedata/share/classes/sun/util/resources/ext/CurrencyNames_ja.properties line 63: > 61: # written authorization of the copyright holder. > 62: > 63: ADP=ADP Same here with `de` bundle. src/jdk.localedata/share/classes/sun/util/resources/ext/CurrencyNames_zh_CN.properties line 63: > 61: # written authorization of the copyright holder. > 62: > 63: ADP=ADP and here. - PR: https://git.openjdk.java.net/jdk/pull/7765
Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote:
>> msg drop for jdk19, Mar 9, 2022
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> moved CurrencyNames changes to jdk.localedata
src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java
line 305:
> 303: {"Thread not suspended", "Thread nicht unterbrochen"},
> 304: {"thread group number description name", "{0,number,integer}.
> {1} {2}"},
> 305: {"Threadgroup name not specified.", "Name der Threadgruppe nicht
> angegeben."},
Same comment here as mentioned in TTYResources_ja.java.
src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java
line 342:
> 340: {"watch modification of", "\u00C4nderung von {0}.{1}
> \u00FCberwachen"},
> 341: {"zz help text",
> 342: "** Befehlsliste **\nconnectors-- Listet
> verf\u00FCgbare Connectors und Transporte in dieser VM auf\n\nrun [class
> [args]]-- Startet die Ausf\u00FChrung der Hauptklasse der
> Anwendung\n\nthreads [threadgroup] -- Listet Threads auf\nthread
> -- Legt den Standardthread fest\nsuspend [thread id(s)]
> -- Unterbricht Threads (Standard: all)\nresume [thread id(s)]-- Nimmt
> Threads wieder auf (Standard: all)\nwhere [ | all] -- Gibt den
> Stack eines Threads aus\nwherei [ | all] -- Gibt den Stack eines
> Threads mit PC-Informationen aus\nup [n frames] -- Verschiebt den
> Stack eines Threads nach oben\ndown [n frames] -- Verschiebt den
> Stack eines Threads nach unten\nkill -- Bricht einen
> Thread mit dem angegebenen Ausnahmeobjekt ab\ninterrupt --
> Unterbricht einen Thread\n\nprint -- Gibt den Wert
> eines Ausdrucks aus\ndump-- Gibt alle Objektinformationen aus\neval
-- Bewertet einen Ausdruck (wie \"print\")\nset =
-- Weist einem Feld/einer Variablen/einem Arrayelement einen
neuen Wert zu\nlocals-- Gibt alle lokalen Variablen im
aktuellen Stackframe aus\n\nclasses -- Listet derzeit
bekannte Klassen auf\nclass -- Zeigt Details einer
benannten Klasse an\nmethods -- Listet die Methoden einer
Klasse auf\nfields -- Listet die Felder einer Klasse
auf\n\nthreadgroups -- Listet Threadgruppen auf\nthreadgroup
-- Legt die aktuelle Threadgruppe fest\n\nstop [go|thread]
[] \n -- Legt einen
Breakpoint fest\n -- Wenn Sie keine Optionen angeben,
wird die aktuelle Breakpoint-Liste ausgegeben\n --
Wenn Sie \"go\" angeben,
wird der Vorgang nach dem Stoppen sofort wiederaufgenommen\n
-- Wenn Sie \"thread\" angeben, wird nur der Thread unterbrochen, in
dem gestoppt wurde\n -- Wenn Sie weder \"go\" noch
\"thread\" angeben, werden alle Threads unterbrochen\n
-- Wenn Sie eine ganzzahlige angeben, wird der Vorgang nur im
angegebenen Thread gestoppt\n -- \"at\" und \"in\"
haben die gleiche Bedeutung\n -- kann eine
Zeilennummer oder eine Methode sein:\n --
:\n --
.[(argument_type,...)]\nclear .[(argument_type,...)]\n -- L\u00F6scht
einen Breakpoint in einer Methode\nclear : -- L\u00F6scht
einen Breakpoint bei einer Zeile\nclear -- Listet
Breakpoints auf\ncatch [uncaught|caught|all] |\n -- Break bei der
angegebenen Ausnahme\nignore [uncaught|caught|all]
|\n -- Bricht \"catch\"
f\u00FCr die angegebene Ausnahme ab\nwatch [access|all]
.\n -- \u00DCberwacht
Zugriffe/\u00C4nderungen eines Feldes\nunwatch [access|all]
.\n -- Hebt die \u00DCberwachung
der Zugriffe/\u00C4nderungen eines Feldes auf\ntrace [go] methods [thread]\n
-- Verfolgt Methodenstarts und -beendigungen.\n
-- Alle Threads werden unterbrochen, es sei denn, \"go\" ist
angegeben\ntrace [go] method exit | exits [thread]\n
-- Verfolgt die Beendigung der aktuellen Methode oder die Beendigungen aller
Methoden\n -- Alle Threads werden unterbrochen, es sei
denn, \"go\" ist angegeben\nuntrace [methods] -- Stoppt
das Tracing von Methodenstarts und/oder -beendigungen\nstep
-- F\u00FChrt die aktuelle Zeile aus\nstep up --
Ausf\u00FChren, bis die aktuelle Methode an den Aufrufer zur\u00FCckgegeben
wird\nstepi -- F\u00FChrt die aktuelle Anweisung aus\nnext
-- Eine Zeile weiter (Aufrufe auslassen)\ncont
-- Setzt die Ausf\u00FChrung ab
Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]
> msg drop for jdk19, Mar 9, 2022 Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: moved CurrencyNames changes to jdk.localedata - Changes: - all: https://git.openjdk.java.net/jdk/pull/7765/files - new: https://git.openjdk.java.net/jdk/pull/7765/files/fb51cf60..4735722d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7765=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7765=00-01 Stats: 2807 lines in 6 files changed: 693 ins; 1527 del; 587 mod Patch: https://git.openjdk.java.net/jdk/pull/7765.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7765/head:pull/7765 PR: https://git.openjdk.java.net/jdk/pull/7765
Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10
On Thu, 10 Mar 2022 17:00:09 GMT, Naoto Sato wrote: > IIRC, localized resource files should have the same copyright year as the > base English one. That's what I was told by the l10n engineer when I had the > same comment. Thanks Naoto! I have no objection then. - PR: https://git.openjdk.java.net/jdk/pull/7765
Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote: > msg drop for jdk19, Mar 9, 2022 IIRC, localized resource files should have the same copyright year as the base English one. That's what I was told by the l10n engineer when I had the same comment. - PR: https://git.openjdk.java.net/jdk/pull/7765
Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote: > msg drop for jdk19, Mar 9, 2022 For simple webserver resource files - should the copyright year be 2022? - PR: https://git.openjdk.java.net/jdk/pull/7765
Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote: > msg drop for jdk19, Mar 9, 2022 For the bundles in java.xml: For files with Oracle copyright, update the year to 2022 and @LastModified Mar 2022. Take XPATHErrorResources_ja.java as an example, the copyright year was updated to 2021 and @LastModified: Nov 2021. That's probably the date it was last modified, but as we updating them now along with a number of other files, it would be good to be consistent and change all of them to the current date. For files with the reserved comment block such as SerializerMessages_de.java, do the same as did in XPATHErrorResources_de.java, add the copyright header and LastModified tag with the current date. For files with the Oracle GPL license such as message_zh_CN.properties, do not delete the license header. Instead, update the copyright year to 2022 if there are changes. I don't see any changes were made for many of these files, for example from msg/XMLSchemaMessages_ja.properties to regex/message_zh_CN.properties, the only change was the removal of the header. In the webrev view, some files have the word "undefined" right under the license header, hopefully once the license header is fixed, that would go away as well. - PR: https://git.openjdk.java.net/jdk/pull/7765
Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote: > msg drop for jdk19, Mar 9, 2022 `src/java.base/share/classes/sun/util/resources/CurrencyNames_de.properties` `src/java.base/share/classes/sun/util/resources/CurrencyNames_ja.properties` `src/java.base/share/classes/sun/util/resources/CurrencyNames_zh_CN.properties` These are part of `jdk.localedata` module. Should be excluded from `java.base` module and apply the diffs to `src/jdk.localedata/share/classes/sun/util/resources/ext/CurrencyNames_xx.properties` manually. (Note that the first half of it is not necessary when merging). - PR: https://git.openjdk.java.net/jdk/pull/7765
RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10
msg drop for jdk19, Mar 9, 2022 - Commit messages: - open jdk19 l10n msg drop Changes: https://git.openjdk.java.net/jdk/pull/7765/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7765=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280400 Stats: 13775 lines in 142 files changed: 12170 ins; 1249 del; 356 mod Patch: https://git.openjdk.java.net/jdk/pull/7765.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7765/head:pull/7765 PR: https://git.openjdk.java.net/jdk/pull/7765
