Re: RFR: 8281631: HashMap copy constructor and putAll can over-allocate table [v19]
On Fri, 18 Feb 2022 18:32:31 GMT, Stuart Marks wrote: >> XenoAmess has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - migrate to junit >> - change threshold > > Sigh. (I'm sighing at the author of the > Enum/ConstantDirectoryOptimalCapacity.java test, not you.) What a mess. See > https://bugs.openjdk.java.net/browse/JDK-8282120 which I just filed. The > broken test and the OptimalCapacity utilities are mostly useless, so the > change to that test and Class.java should be removed this PR, and the test > added to the Problem List so it doesn't get run anymore. See > test/jdk/ProblemList.txt and add an entry for the now-failing test, with a > reference to 8282120. > > I don't think I'll have time to look at the junit rewrite and to run this > through our internal build/test system today, so sorry, this may need to wait > a week. @stuart-marks changes done, floats converted to doubles before calculations. please have a look. Thanks. - PR: https://git.openjdk.java.net/jdk/pull/7431
Re: RFR: 8281631: HashMap copy constructor and putAll can over-allocate table [v19]
On Fri, 18 Feb 2022 18:32:31 GMT, Stuart Marks wrote: >> XenoAmess has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - migrate to junit >> - change threshold > > Sigh. (I'm sighing at the author of the > Enum/ConstantDirectoryOptimalCapacity.java test, not you.) What a mess. See > https://bugs.openjdk.java.net/browse/JDK-8282120 which I just filed. The > broken test and the OptimalCapacity utilities are mostly useless, so the > change to that test and Class.java should be removed this PR, and the test > added to the Problem List so it doesn't get run anymore. See > test/jdk/ProblemList.txt and add an entry for the now-failing test, with a > reference to 8282120. > > I don't think I'll have time to look at the junit rewrite and to run this > through our internal build/test system today, so sorry, this may need to wait > a week. @stuart-marks changes to IdentityHashMap reverted. please review again. thanks. - PR: https://git.openjdk.java.net/jdk/pull/7431
Re: RFR: 8281631: HashMap copy constructor and putAll can over-allocate table [v19]
On Fri, 18 Feb 2022 18:32:31 GMT, Stuart Marks wrote: > Sigh. (I'm sighing at the author of the > Enum/ConstantDirectoryOptimalCapacity.java test, not you.) What a mess. See > https://bugs.openjdk.java.net/browse/JDK-8282120 which I just filed. The > broken test and the OptimalCapacity utilities are mostly useless, so the > change to that test and Class.java should be removed this PR, and the test > added to the Problem List so it doesn't get run anymore. See > test/jdk/ProblemList.txt and add an entry for the now-failing test, with a > reference to 8282120. Got it. I would have a try. > I don't think I'll have time to look at the junit rewrite and to run this > through our internal build/test system today, so sorry, this may need to wait > a week. OK, see you next week~ - PR: https://git.openjdk.java.net/jdk/pull/7431
Re: RFR: 8281631: HashMap copy constructor and putAll can over-allocate table [v19]
On Fri, 18 Feb 2022 15:29:25 GMT, XenoAmess wrote: >> 8281631: HashMap copy constructor and putAll can over-allocate table > > XenoAmess has updated the pull request incrementally with two additional > commits since the last revision: > > - migrate to junit > - change threshold Sigh. (I'm sighing at the author of the Enum/ConstantDirectoryOptimalCapacity.java test, not you.) What a mess. See https://bugs.openjdk.java.net/browse/JDK-8282120 which I just filed. The broken test and the OptimalCapacity utilities are mostly useless, so the change to that test and Class.java should be removed this PR, and the test added to the Problem List so it doesn't get run anymore. See test/jdk/ProblemList.txt and add an entry for the now-failing test, with a reference to 8282120. I don't think I'll have time to look at the junit rewrite and to run this through our internal build/test system today, so sorry, this may need to wait a week. - PR: https://git.openjdk.java.net/jdk/pull/7431
Re: RFR: 8281631: HashMap copy constructor and putAll can over-allocate table [v19]
> 8281631: HashMap copy constructor and putAll can over-allocate table XenoAmess has updated the pull request incrementally with two additional commits since the last revision: - migrate to junit - change threshold - Changes: - all: https://git.openjdk.java.net/jdk/pull/7431/files - new: https://git.openjdk.java.net/jdk/pull/7431/files/cdfb03bb..aa599698 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7431=18 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7431=17-18 Stats: 64 lines in 2 files changed: 17 ins; 17 del; 30 mod Patch: https://git.openjdk.java.net/jdk/pull/7431.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7431/head:pull/7431 PR: https://git.openjdk.java.net/jdk/pull/7431
