On Wed, 6 Apr 2022 06:23:47 GMT, Jatin Bhateja wrote:
>>> Also need a jtreg test for this.
>>
>> Thanks Sandhya for the review. Made the suggested changes and added jtreg
>> tests as well.
>
> Hi @vamsi-parasa , thanks for addressing my comments, looks good to me
> otherwise apart from the
On Wed, 6 Apr 2022 00:45:37 GMT, Vladimir Kozlov wrote:
>> Thanks for suggesting the enhancement. This enhancement will be implemented
>> as a part of https://bugs.openjdk.java.net/browse/JDK-8282365
>
> You do need `Ideal()` methods at least to check for dead code.
Added the Ideal() methods
On Mon, 4 Apr 2022 07:24:12 GMT, Vamsi Parasa wrote:
>> Also need a jtreg test for this.
>
>> Also need a jtreg test for this.
>
> Thanks Sandhya for the review. Made the suggested changes and added jtreg
> tests as well.
Hi @vamsi-parasa , thanks for addressing my comments, looks good to me
On Thu, 24 Feb 2022 19:04:37 GMT, Vamsi Parasa wrote:
>> src/hotspot/share/opto/divnode.cpp line 881:
>>
>>> 879: return (phase->type( in(2) )->higher_equal(TypeLong::ONE)) ? in(1) :
>>> this;
>>> 880: }
>>> 881:
>>>
On Thu, 24 Feb 2022 14:13:47 GMT, Jatin Bhateja wrote:
>> Vamsi Parasa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix 32bit build issues
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 4408:
>
>> 4406: jmp(done);
>> 4407:
On Thu, 24 Feb 2022 02:43:46 GMT, Vamsi Parasa wrote:
>> Optimizes the divideUnsigned() and remainderUnsigned() methods in
>> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
>> change shows 3x improvement for Integer methods and upto 25% improvement for
>> Long. This
> Optimizes the divideUnsigned() and remainderUnsigned() methods in
> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
> change shows 3x improvement for Integer methods and upto 25% improvement for
> Long. This change also implements the DivMod optimization which fuses
>
