Re: RFR: 8282551: Properly initialize L32X64MixRandom state

2022-03-02 Thread Kevin Rushforth
On Wed, 2 Mar 2022 15:26:35 GMT, Devin Smith wrote: > Thanks for the help. I signed the OCA on Jan 17, 2022 and got confirmation it > was approved on Jan 20, 2022. Correct. Reviewers may know that this has been recorded if the PR has no `oca` label (you can see above that the `oca` label was

Re: RFR: 8282551: Properly initialize L32X64MixRandom state

2022-03-02 Thread Devin Smith
On Tue, 18 Jan 2022 01:39:52 GMT, Devin Smith wrote: > Did a cursory review of the other generators, they seem to set the state > correctly. Thanks for the help. I signed the OCA on Jan 17, 2022 and got confirmation it was approved on Jan 20, 2022. - PR:

Re: RFR: 8282551: Properly initialize L32X64MixRandom state

2022-03-02 Thread Devin Smith
On Tue, 18 Jan 2022 01:39:52 GMT, Devin Smith wrote: > Did a cursory review of the other generators, they seem to set the state > correctly. @JimLaskey would it be possible to create an issue and review this change? I don't have an account on the OpenJDK issue tracker. I'm not sure how to

Re: RFR: 8282551: Properly initialize L32X64MixRandom state

2022-03-02 Thread Daniel Jeliński
On Tue, 18 Jan 2022 01:39:52 GMT, Devin Smith wrote: > Did a cursory review of the other generators, they seem to set the state > correctly. Created https://bugs.openjdk.java.net/browse/JDK-8282551 for this. @devinrsmith please change the issue title to `8282551: Properly initialize

Re: RFR: 8282551: Properly initialize L32X64MixRandom state

2022-03-02 Thread Daniel Jeliński
On Mon, 21 Feb 2022 19:43:52 GMT, Devin Smith wrote: >> Did a cursory review of the other generators, they seem to set the state >> correctly. > > I'm not sure how to move this forward, or get the attention of the people > responsible for this code. I see @turbanoff you liked and may be

RFR: 8282551: Properly initialize L32X64MixRandom state

2022-03-02 Thread Devin Smith
Did a cursory review of the other generators, they seem to set the state correctly. - Commit messages: - [PATCH] Properly initialize L32X64MixRandom state Changes: https://git.openjdk.java.net/jdk/pull/7120/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7120=00 Issue:

Re: RFR: 8282551: Properly initialize L32X64MixRandom state

2022-03-02 Thread Jim Laskey
On Tue, 18 Jan 2022 01:39:52 GMT, Devin Smith wrote: > Did a cursory review of the other generators, they seem to set the state > correctly. Marked as reviewed by jlaskey (Reviewer). I'll sponsor this change when you receive your OCA. - PR: