Re: RFR: 8282648: Problems due to conflicting specification of Inflater::inflate(..) and InflaterInputStream::read(..) [v2]

2022-05-13 Thread Lance Andersen
On Wed, 30 Mar 2022 10:26:56 GMT, Lance Andersen wrote: >>> Hello Volker, An additional thing that we might have to consider here is >>> whether adding this javadoc change to `InflaterInputStream` is ever going >>> to "show up" to end user applications. What I mean is, I think in many >>>

Re: RFR: 8282648: Problems due to conflicting specification of Inflater::inflate(..) and InflaterInputStream::read(..) [v2]

2022-05-05 Thread Volker Simonis
On Wed, 30 Mar 2022 10:26:56 GMT, Lance Andersen wrote: >>> Hello Volker, An additional thing that we might have to consider here is >>> whether adding this javadoc change to `InflaterInputStream` is ever going >>> to "show up" to end user applications. What I mean is, I think in many >>>

Re: RFR: 8282648: Problems due to conflicting specification of Inflater::inflate(..) and InflaterInputStream::read(..) [v2]

2022-03-30 Thread Lance Andersen
On Tue, 29 Mar 2022 12:45:51 GMT, Volker Simonis wrote: > > Hello Volker, An additional thing that we might have to consider here is > > whether adding this javadoc change to `InflaterInputStream` is ever going > > to "show up" to end user applications. What I mean is, I think in many > >

Re: RFR: 8282648: Problems due to conflicting specification of Inflater::inflate(..) and InflaterInputStream::read(..) [v2]

2022-03-29 Thread Volker Simonis
On Tue, 29 Mar 2022 01:58:05 GMT, Jaikiran Pai wrote: > Hello Volker, An additional thing that we might have to consider here is > whether adding this javadoc change to `InflaterInputStream` is ever going to > "show up" to end user applications. What I mean is, I think in many cases the > end

Re: RFR: 8282648: Problems due to conflicting specification of Inflater::inflate(..) and InflaterInputStream::read(..) [v2]

2022-03-29 Thread Volker Simonis
On Mon, 28 Mar 2022 18:23:46 GMT, Lance Andersen wrote: >> I think this require a bit of word smithing. If the return value is 'n' then >> it should make it clear that the values in elements b[off + n] to b[off + >> len - 1] are undefined, their values may or may have been changed by the >>

Re: RFR: 8282648: Problems due to conflicting specification of Inflater::inflate(..) and InflaterInputStream::read(..) [v2]

2022-03-28 Thread Jaikiran Pai
On Mon, 28 Mar 2022 10:55:30 GMT, Volker Simonis wrote: >> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` >> to highlight that it might write more bytes than the returned number of >> inflated bytes into the buffer `b`. >> >> The superclass `java.io.InputStream`

Re: RFR: 8282648: Problems due to conflicting specification of Inflater::inflate(..) and InflaterInputStream::read(..) [v2]

2022-03-28 Thread Lance Andersen
On Mon, 28 Mar 2022 17:21:40 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/util/zip/InflaterInputStream.java line 133: >> >>> 131: * Unlike the {@link InputStream#read(byte[],int,int) overridden >>> method} >>> 132: * of {@code InputStream}, this method might write

Re: RFR: 8282648: Problems due to conflicting specification of Inflater::inflate(..) and InflaterInputStream::read(..) [v2]

2022-03-28 Thread Alan Bateman
On Mon, 28 Mar 2022 15:01:30 GMT, Jaikiran Pai wrote: >> Volker Simonis has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new

Re: RFR: 8282648: Problems due to conflicting specification of Inflater::inflate(..) and InflaterInputStream::read(..) [v2]

2022-03-28 Thread Jaikiran Pai
On Mon, 28 Mar 2022 10:55:30 GMT, Volker Simonis wrote: >> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` >> to highlight that it might write more bytes than the returned number of >> inflated bytes into the buffer `b`. >> >> The superclass `java.io.InputStream`

Re: RFR: 8282648: Problems due to conflicting specification of Inflater::inflate(..) and InflaterInputStream::read(..) [v2]

2022-03-28 Thread Volker Simonis
> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` to > highlight that it might write more bytes than the returned number of > inflated bytes into the buffer `b`. > > The superclass `java.io.InputStream` specifies that `read(byte[] b, int off, > int len)` will leave