Re: RFR: 8282929: Localized monetary symbols are not reflected in `toLocalizedPattern` return value [v2]
On Sat, 12 Mar 2022 16:27:51 GMT, Lance Andersen wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refined the test > > test/jdk/java/text/Format/DecimalFormat/ToLocalizedPatternTest.java line 29: > >> 27: * @summary Verifies that toLocalizedPattern() method correctly returns >> 28: * monetary symbols in a currency formatter >> 29: * @run testng ToLocalizedPatternTest > > Maybe run in othervm mode? Thanks, Lance. I believe it is OK to run it in samejvm mode, as it does not leave any side effects. - PR: https://git.openjdk.java.net/jdk/pull/7790
Re: RFR: 8282929: Localized monetary symbols are not reflected in `toLocalizedPattern` return value [v2]
On Fri, 11 Mar 2022 22:20:38 GMT, Naoto Sato wrote: >> `DecimalFormat.toLocalizedPattern()` was not honoring the monetary >> decimal/grouping separator symbols. Fix is straightforward to use the >> correct symbols depending on the formatter type. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Refined the test Marked as reviewed by lancea (Reviewer). test/jdk/java/text/Format/DecimalFormat/ToLocalizedPatternTest.java line 29: > 27: * @summary Verifies that toLocalizedPattern() method correctly returns > 28: * monetary symbols in a currency formatter > 29: * @run testng ToLocalizedPatternTest Maybe run in othervm mode? - PR: https://git.openjdk.java.net/jdk/pull/7790
Re: RFR: 8282929: Localized monetary symbols are not reflected in `toLocalizedPattern` return value [v2]
On Fri, 11 Mar 2022 22:20:38 GMT, Naoto Sato wrote: >> `DecimalFormat.toLocalizedPattern()` was not honoring the monetary >> decimal/grouping separator symbols. Fix is straightforward to use the >> correct symbols depending on the formatter type. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Refined the test Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7790
Re: RFR: 8282929: Localized monetary symbols are not reflected in `toLocalizedPattern` return value [v2]
> `DecimalFormat.toLocalizedPattern()` was not honoring the monetary > decimal/grouping separator symbols. Fix is straightforward to use the correct > symbols depending on the formatter type. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Refined the test - Changes: - all: https://git.openjdk.java.net/jdk/pull/7790/files - new: https://git.openjdk.java.net/jdk/pull/7790/files/a6cbf914..5064e354 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7790=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7790=00-01 Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/7790.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7790/head:pull/7790 PR: https://git.openjdk.java.net/jdk/pull/7790
