Re: RFR: 8283287: ClassLoader.c cleanups [v2]

2022-03-18 Thread Alan Bateman
On Thu, 17 Mar 2022 16:08:11 GMT, Tyler Steele  wrote:

>> As mentioned in the issue, I'd like to perform the following tidying on 
>> ClassLoader.c
>> 
>> - Alphabetize includes.
>> - Replace 'if (ptr == 0)' with 'if (ptr == NULL)'.
>> - Replace 'return 0' with 'return NULL'.
>
> Tyler Steele has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   removes unneeded errno.h

Marked as reviewed by alanb (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/7846


Re: RFR: 8283287: ClassLoader.c cleanups [v2]

2022-03-17 Thread Thomas Stuefe
On Thu, 17 Mar 2022 16:08:11 GMT, Tyler Steele  wrote:

>> As mentioned in the issue, I'd like to perform the following tidying on 
>> ClassLoader.c
>> 
>> - Alphabetize includes.
>> - Replace 'if (ptr == 0)' with 'if (ptr == NULL)'.
>> - Replace 'return 0' with 'return NULL'.
>
> Tyler Steele has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   removes unneeded errno.h

All good.

Cheers, Thomas

-

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7846


Re: RFR: 8283287: ClassLoader.c cleanups [v2]

2022-03-17 Thread Tyler Steele
> As mentioned in the issue, I'd like to perform the following tidying on 
> ClassLoader.c
> 
> - Alphabetize includes.
> - Replace 'if (ptr == 0)' with 'if (ptr == NULL)'.
> - Replace 'return 0' with 'return NULL'.

Tyler Steele has updated the pull request incrementally with one additional 
commit since the last revision:

  removes unneeded errno.h

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7846/files
  - new: https://git.openjdk.java.net/jdk/pull/7846/files/57a92415..920e76fb

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=7846=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7846=00-01

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7846.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7846/head:pull/7846

PR: https://git.openjdk.java.net/jdk/pull/7846