On Tue, 7 Jun 2022 21:19:02 GMT, Brent Christian wrote:
> > The commented out printf/println's should be removed before committing.
>
> Do you mean the pre-existing `println`s in LdapSearchEnumeration.java?
Usually, I would mean any that were added for this issue.
The changes in indentation (as
On Tue, 7 Jun 2022 18:45:17 GMT, Roger Riggs wrote:
> The commented out printf/println's should be removed before committing.
Do you mean the pre-existing `println`s in LdapSearchEnumeration.java?
-
PR: https://git.openjdk.java.net/jdk/pull/8311
On Mon, 6 Jun 2022 21:59:56 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to a
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a static inner class . From
> there, the change is fairly mechan