On Fri, 13 May 2022 19:59:40 GMT, Jorn Vernee wrote:
>> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 933:
>>
>>> 931: } else {
>>> 932: assert(dst.is_single_reg(), "not a stack pair: (%s, %s), (%s,
>>> %s)",
>>> 933: src.first()->name(), src.second()->name(),
>>>
On Fri, 13 May 2022 20:46:19 GMT, Vladimir Ivanov wrote:
>> Shouldn't there be a 2-space indentation wrt the assert here? I could also
>> indent all the arguments to be aligned with the format string, if that seems
>> better.
>
> It's preferred to indent multi-line argument lists on the column
On Fri, 13 May 2022 19:16:36 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 98 commits:
>>
>> - Merge branch 'master' into JEP-19-VM-IMPL2
>> - Undo spurious changes.
>> - Merge
On Thu, 12 May 2022 16:58:36 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR updates the VM implementation of the foreign linker, by bringing
>> over commits from the panama-foreign repo.
>>
>> This is split off from the main JEP integration for 19, since we have
>> limited resources to handle
> Hi,
>
> This PR updates the VM implementation of the foreign linker, by bringing over
> commits from the panama-foreign repo.
>
> This is split off from the main JEP integration for 19, since we have limited
> resources to handle this. As such, this PR might fall over to 20, but it
> would