Re: RFR: 8284400: Improve XPath exception handling [v2]
On Fri, 27 May 2022 17:17:28 GMT, Joe Wang wrote: >> Addresses an insufficiency of error handling in the XPath implementation. >> Some cleanup where appropriate, without attempting to do too much as this is >> a component that hasn't had much changes for 15 years, a fairly stable >> application. >> >> Test: tier2 passed >> JCK: JCK XML tests passed > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > update copyright year and LastModified tag Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8910
Re: RFR: 8284400: Improve XPath exception handling
On Fri, 27 May 2022 01:12:18 GMT, Joe Wang wrote: > Addresses an insufficiency of error handling in the XPath implementation. > Some cleanup where appropriate, without attempting to do too much as this is > a component that hasn't had much changes for 15 years, a fairly stable > application. > > Test: tier2 passed > JCK: JCK XML tests passed Thanks Lance, Naoto! Updated copyright year and LastModified tag. - PR: https://git.openjdk.java.net/jdk/pull/8910
Re: RFR: 8284400: Improve XPath exception handling [v2]
> Addresses an insufficiency of error handling in the XPath implementation. > Some cleanup where appropriate, without attempting to do too much as this is > a component that hasn't had much changes for 15 years, a fairly stable > application. > > Test: tier2 passed > JCK: JCK XML tests passed Joe Wang has updated the pull request incrementally with one additional commit since the last revision: update copyright year and LastModified tag - Changes: - all: https://git.openjdk.java.net/jdk/pull/8910/files - new: https://git.openjdk.java.net/jdk/pull/8910/files/a03cb0d4..12575c95 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=8910=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8910=00-01 Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/8910.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8910/head:pull/8910 PR: https://git.openjdk.java.net/jdk/pull/8910
Re: RFR: 8284400: Improve XPath exception handling
On Fri, 27 May 2022 01:12:18 GMT, Joe Wang wrote: > Addresses an insufficiency of error handling in the XPath implementation. > Some cleanup where appropriate, without attempting to do too much as this is > a component that hasn't had much changes for 15 years, a fairly stable > application. > > Test: tier2 passed > JCK: JCK XML tests passed LGTM. Nit: some files have old copyright years and/or `@LastModified` fields - Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8910
Re: RFR: 8284400: Improve XPath exception handling
On Fri, 27 May 2022 01:12:18 GMT, Joe Wang wrote: > Addresses an insufficiency of error handling in the XPath implementation. > Some cleanup where appropriate, without attempting to do too much as this is > a component that hasn't had much changes for 15 years, a fairly stable > application. > > Test: tier2 passed > JCK: JCK XML tests passed Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8910
RFR: 8284400: Improve XPath exception handling
Address some insufficiency of error handling in the XPath implementation. Some cleanup where appropriate, without attempting to do too much as this is an component that hasn't had much changes for 15 years, a fairly stable application. - Commit messages: - 8284400: Improve XPath exception handling Changes: https://git.openjdk.java.net/jdk/pull/8910/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8910=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8284400 Stats: 861 lines in 11 files changed: 617 ins; 179 del; 65 mod Patch: https://git.openjdk.java.net/jdk/pull/8910.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8910/head:pull/8910 PR: https://git.openjdk.java.net/jdk/pull/8910
