Re: RFR: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException [v2]

2022-04-20 Thread Lance Andersen 
On Wed, 20 Apr 2022 21:53:46 GMT, Joe Wang  wrote:

>> Patch note:
>> 
>> A previous patch had a bug that missed the boundary check, that will cause 
>> StringIndexOutOfBoundsException to be thrown instead of 
>> XPathExpressionException as expected.
>> 
>> Fix: the fix is to check the boundaries of the parameter "index". 
>> Objects.checkIndex is removed as it's redundant.
>
> Joe Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   add the test

Marked as reviewed by lancea (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8323

Re: RFR: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException [v2]

2022-04-20 Thread Joe Wang 
> Patch note:
> 
> A previous patch had a bug that missed the boundary check, that will cause 
> StringIndexOutOfBoundsException to be thrown instead of 
> XPathExpressionException as expected.
> 
> Fix: the fix is to check the boundaries of the parameter "index". 
> Objects.checkIndex is removed as it's redundant.

Joe Wang has updated the pull request incrementally with one additional commit 
since the last revision:

  add the test

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8323/files
  - new: https://git.openjdk.java.net/jdk/pull/8323/files/4205ea6f..17b8c3e6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=8323=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8323=00-01

  Stats: 82 lines in 1 file changed: 82 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8323.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8323/head:pull/8323

PR: https://git.openjdk.java.net/jdk/pull/8323

Re: RFR: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException

2022-04-20 Thread Naoto Sato 
On Wed, 20 Apr 2022 20:08:01 GMT, Joe Wang  wrote:

> Patch note:
> 
> A previous patch had a bug that missed the boundary check, that will 
> cause StringIndexOutOfBoundsException to be thrown instead of 
> XPathExpressionException as expected.
> 
> Fix: the fix is to check the boundaries of the parameter "index". 
> Objects.checkIndex is removed as it's redundant.

Marked as reviewed by naoto (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8323

RFR: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException

2022-04-20 Thread Joe Wang 
Patch note:

A previous patch had a bug that missed the boundary check, that will cause 
StringIndexOutOfBoundsException to be thrown instead of 
XPathExpressionException as expected.

Fix: the fix is to check the boundaries of the parameter "index". 
Objects.checkIndex is removed as it's redundant.

-

Commit messages:
 - 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException

Changes: https://git.openjdk.java.net/jdk/pull/8323/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8323=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8284548
  Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8323.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8323/head:pull/8323

PR: https://git.openjdk.java.net/jdk/pull/8323