Re: RFR: 8284702: Add @since for java.time.LocalDate.EPOCH
On Tue, 12 Apr 2022 03:21:00 GMT, Glavo wrote: > `java.time.LocalDate.EPOCH` was introduced in Java 9, but there is no > corresponding `@since` in the javadoc. The absence of `@since` makes it > impossible for IDEs to check for misuse of it, it may be misused by users > targeting Java 8 and crash at runtime. This highly nontrivial change really requires a lot of people to review! But it looks pretty legitimate to me. - Marked as reviewed by ice1...@github.com (no known OpenJDK username). PR: https://git.openjdk.java.net/jdk/pull/8192
Re: RFR: 8284702: Add @since for java.time.LocalDate.EPOCH
On Tue, 12 Apr 2022 03:21:00 GMT, Glavo wrote: > `java.time.LocalDate.EPOCH` was introduced in Java 9, but there is no > corresponding `@since` in the javadoc. The absence of `@since` makes it > impossible for IDEs to check for misuse of it, it may be misused by users > targeting Java 8 and crash at runtime. Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8192
Re: RFR: 8284702: Add @since for java.time.LocalDate.EPOCH
On Tue, 12 Apr 2022 03:21:00 GMT, Glavo wrote: > `java.time.LocalDate.EPOCH` was introduced in Java 9, but there is no > corresponding `@since` in the javadoc. The absence of `@since` makes it > impossible for IDEs to check for misuse of it, it may be misused by users > targeting Java 8 and crash at runtime. The @since tag was omitted as part of JDK-8143413 and it is good to add it now. - Marked as reviewed by darcy (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8192
Re: RFR: 8284702: Add @since for java.time.LocalDate.EPOCH
On Tue, 12 Apr 2022 03:21:00 GMT, Glavo wrote: > `java.time.LocalDate.EPOCH` was introduced in Java 9, but there is no > corresponding `@since` in the javadoc. The absence of `@since` makes it > impossible for IDEs to check for misuse of it, it may be misused by users > targeting Java 8 and crash at runtime. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8192
Re: RFR: 8284702: Add @since for java.time.LocalDate.EPOCH
On Tue, 12 Apr 2022 03:21:00 GMT, Glavo wrote: > `java.time.LocalDate.EPOCH` was introduced in Java 9, but there is no > corresponding `@since` in the javadoc. The absence of `@since` makes it > impossible for IDEs to check for misuse of it, it may be misused by users > targeting Java 8 and crash at runtime. Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8192
Re: RFR: 8284702: Add @since for java.time.LocalDate.EPOCH
On Tue, 12 Apr 2022 03:21:00 GMT, Glavo wrote: > `java.time.LocalDate.EPOCH` was introduced in Java 9, but there is no > corresponding `@since` in the javadoc. The absence of `@since` makes it > impossible for IDEs to check for misuse of it, it may be misused by users > targeting Java 8 and crash at runtime. LGTM - Marked as reviewed by rriggs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8192
Re: RFR: 8284702: Add @since for java.time.LocalDate.EPOCH
On Tue, 12 Apr 2022 04:41:06 GMT, liach wrote: > Hmm, isn't this misuse detected by `--release 8` in javac flags? Ah, yes, when compiling with `--release 8`, it will prompt `the symbol cannot be found`. But here's the thing: I'm making some Java 11+ projects compatible with Java 8. Since `module-info.java` needs to be compiled, I actually set up `--release 9` and is compatible with Java 8 by transpiling the bytecode, and I check the whole project through IDEA to catch API abuse. For the most part, IDEA works just fine, but it misses `java.time.LocalDate.EPOCH`. The weird crash led me to it, but IDEA didn't warn me, and the lack of `@since` confused me for a while. - PR: https://git.openjdk.java.net/jdk/pull/8192
Re: RFR: 8284702: Add @since for java.time.LocalDate.EPOCH
On Tue, 12 Apr 2022 03:21:00 GMT, Glavo wrote: > `java.time.LocalDate.EPOCH` was introduced in Java 9, but there is no > corresponding `@since` in the javadoc. The absence of `@since` makes it > impossible for IDEs to check for misuse of it, it may be misused by users > targeting Java 8 and crash at runtime. Hmm, isn't this misuse detected by `--release 8` in javac flags? - PR: https://git.openjdk.java.net/jdk/pull/8192
RFR: 8284702: Add @since for java.time.LocalDate.EPOCH
`java.time.LocalDate.EPOCH` was introduced in Java 9, but there is no corresponding `@since` in the javadoc. The absence of `@since` makes it impossible for IDEs to check for misuse of it, it may be misused by users targeting Java 8 and crash at runtime. - Commit messages: - 8284702: Add @since for java.time.LocalDate.EPOCH Changes: https://git.openjdk.java.net/jdk/pull/8192/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8192=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8284702 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/8192.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8192/head:pull/8192 PR: https://git.openjdk.java.net/jdk/pull/8192
