On Thu, 26 May 2022 22:33:29 GMT, Mandy Chung wrote:
>> The original check and `Modules.addOpen` calls were added in
>> [8159476](https://bugs.openjdk.java.net/browse/JDK-8159746), when the
>> `invokeDefault` support was added.
>>
>> See:
>> https://github.com/openjdk/jdk/commit/56b15fbbcc7c0
On Thu, 26 May 2022 22:01:56 GMT, liach wrote:
>> src/java.base/share/classes/java/lang/reflect/Proxy.java line 513:
>>
>>> 511:
>>> 512: if (!module.isOpen(pkg, Proxy.class.getModule())) {
>>> 513: // Required for default method invocation
>>
>> Is
On Thu, 26 May 2022 21:32:53 GMT, Mandy Chung wrote:
>> liach has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains seven additional commits
>> since
On Thu, 26 May 2022 20:53:29 GMT, liach wrote:
>> Currently, in ProxyBuilder::mapToModule and ProxyBuilder::defineProxyClass,
>> the interfaces are iterated twice. The two passes can be merged into one,
>> yielding the whole proxy definition context (module, package, whether
>> there's package
> Currently, in ProxyBuilder::mapToModule and ProxyBuilder::defineProxyClass,
> the interfaces are iterated twice. The two passes can be merged into one,
> yielding the whole proxy definition context (module, package, whether there's
> package-private interface) when determining the module.
>
>