Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al [v3]

2022-06-10 Thread Jaikiran Pai
On Fri, 10 Jun 2022 08:26:02 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which addresses >> https://bugs.openjdk.java.net/browse/JDK-8285405? >> >> I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the >> existing

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al [v3]

2022-06-10 Thread Jaikiran Pai
> Can I please get a review of this change which addresses > https://bugs.openjdk.java.net/browse/JDK-8285405? > > I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing > `test/jdk/java/util/LinkedHashMap/Basic.java` since that test has tests for > various APIs of this

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al [v2]

2022-06-10 Thread Jaikiran Pai
> Can I please get a review of this change which addresses > https://bugs.openjdk.java.net/browse/JDK-8285405? > > I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing > `test/jdk/java/util/LinkedHashMap/Basic.java` since that test has tests for > various APIs of this

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-06-09 Thread Jaikiran Pai
On Mon, 6 Jun 2022 06:57:23 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which addresses > https://bugs.openjdk.java.net/browse/JDK-8285405? > > I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing > `test/jdk/java/util/LinkedHashMap/Basic.java`

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-06-09 Thread Stuart Marks
On Mon, 6 Jun 2022 06:57:23 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which addresses > https://bugs.openjdk.java.net/browse/JDK-8285405? > > I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing > `test/jdk/java/util/LinkedHashMap/Basic.java`

Re: RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-06-08 Thread Lance Andersen
On Mon, 6 Jun 2022 06:57:23 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which addresses > https://bugs.openjdk.java.net/browse/JDK-8285405? > > I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing > `test/jdk/java/util/LinkedHashMap/Basic.java`

RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

2022-06-08 Thread Jaikiran Pai
Can I please get a review of this change which addresses https://bugs.openjdk.java.net/browse/JDK-8285405? I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing `test/jdk/java/util/LinkedHashMap/Basic.java` since that test has tests for various APIs of this class. For