Re: RFR: 8285485: Fix typos in corelibs [v3]
> I ran `codespell` on modules owned by core-libs, and accepted those changes > where it indeed discovered real typos. > > I will update copyright years using a script before pushing (otherwise like > every second change would be a copyright update, making reviewing much > harder). > > The long term goal here is to make tooling support for running `codespell`. > The trouble with automating this is of course all false positives. But before > even trying to solve that issue, all true positives must be fixed. Hence this > PR. Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge branch 'master' into typos-in-corelibs - Fixes comments in review: * Reverting changes in jdwp.spec * Fix "is occurs" * Stop providing "Syncchronication" providers :-) * Fix fEncoder reduplication. * Revert changes in XMLEventReaderImpl.java - Pass #2 core - Pass #1 core - Pass #2 misc - Pass #1 misc - Changes: - all: https://git.openjdk.java.net/jdk/pull/8364/files - new: https://git.openjdk.java.net/jdk/pull/8364/files/b6c00de9..8bc35edb Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8364&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8364&range=01-02 Stats: 228368 lines in 2830 files changed: 173822 ins; 38520 del; 16026 mod Patch: https://git.openjdk.java.net/jdk/pull/8364.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8364/head:pull/8364 PR: https://git.openjdk.java.net/jdk/pull/8364
Re: RFR: 8285485: Fix typos in corelibs [v3]
On Wed, 27 Apr 2022 15:50:20 GMT, Roger Riggs wrote: >> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains six >> additional commits since the last revision: >> >> - Merge branch 'master' into typos-in-corelibs >> - Fixes comments in review: >> >>* Reverting changes in jdwp.spec >>* Fix "is occurs" >>* Stop providing "Syncchronication" providers :-) >>* Fix fEncoder reduplication. >>* Revert changes in XMLEventReaderImpl.java >> - Pass #2 core >> - Pass #1 core >> - Pass #2 misc >> - Pass #1 misc > > Since you've changed some code; you need to run tests for tiers 1-3. > > (Note that even for trivial changes, hundreds of OpenJDK developers are > notified and distracted; be considerate of other developers). I believe I have addressed all feedback in the review, with the possible exception of 3rd party source. @RogerRiggs Are there more 3rd party files I have inadvertently modified, apart from `XMLEventReaderImpl.java`? - PR: https://git.openjdk.java.net/jdk/pull/8364
