Re: RFR: 8285844: TimeZone.getTimeZone(ZoneOffset) does not work for all ZoneOffsets and returns GMT unexpected [v4]
On Wed, 11 May 2022 18:30:32 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor fixup
>
> src/java.base/share/classes/java/util/TimeZone.java line 80:
>
>> 78: * {@code GMT} Sign Hours {@code :} Minutes
>> {@code :} Seconds
>> 79: * {@code GMT} Sign Hours {@code :} Minutes
>> 80: * {@code GMT} Sign Hours Minutes
>
> For hours and minutes, the format can be hh:mm or hhmm. Is it worth it to
> support hhmmss as well?
It would be consistent, but I don't see much requirement for it. I'll consider
if someone needs it.
-
PR: https://git.openjdk.java.net/jdk/pull/8606
Re: RFR: 8285844: TimeZone.getTimeZone(ZoneOffset) does not work for all ZoneOffsets and returns GMT unexpected [v4]
On Wed, 11 May 2022 17:04:41 GMT, Naoto Sato wrote:
>> This is to extend the `Custom ID`s in `java.util.TimeZone` class to support
>> second-level resolution, enabling round trips with `java.time.ZoneOffset`s.
>> Corresponding CSR is also being drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Minor fixup
src/java.base/share/classes/java/util/TimeZone.java line 80:
> 78: * {@code GMT} Sign Hours {@code :} Minutes
> {@code :} Seconds
> 79: * {@code GMT} Sign Hours {@code :} Minutes
> 80: * {@code GMT} Sign Hours Minutes
For hours and minutes, the format can be hh:mm or hhmm. Is it worth it to
support hhmmss as well?
-
PR: https://git.openjdk.java.net/jdk/pull/8606
Re: RFR: 8285844: TimeZone.getTimeZone(ZoneOffset) does not work for all ZoneOffsets and returns GMT unexpected [v4]
> This is to extend the `Custom ID`s in `java.util.TimeZone` class to support > second-level resolution, enabling round trips with `java.time.ZoneOffset`s. > Corresponding CSR is also being drafted. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Minor fixup - Changes: - all: https://git.openjdk.java.net/jdk/pull/8606/files - new: https://git.openjdk.java.net/jdk/pull/8606/files/fcdaf512..9722decd Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=8606=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8606=02-03 Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/8606.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8606/head:pull/8606 PR: https://git.openjdk.java.net/jdk/pull/8606
