Re: RFR: 8286287: Reading file as UTF-16 causes Error which "shouldn't happen" [v2]

2022-05-11 Thread Roger Riggs 
On Wed, 11 May 2022 15:52:59 GMT, Naoto Sato  wrote:

>> `String.decodeWithDecoder()` method requires the `CharsetDecoder` parameter 
>> replaces on malformed/unmappable characters with replacements. However, 
>> there was a code path that lacked to set the `CodingErrorAction.REPLACE` on 
>> the decoder. Unrelated, one typo in a test was also fixed.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Reverted the typo fix

Marked as reviewed by rriggs (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8640

Re: RFR: 8286287: Reading file as UTF-16 causes Error which "shouldn't happen" [v2]

2022-05-11 Thread Naoto Sato 
> `String.decodeWithDecoder()` method requires the `CharsetDecoder` parameter 
> replaces on malformed/unmappable characters with replacements. However, there 
> was a code path that lacked to set the `CodingErrorAction.REPLACE` on the 
> decoder. Unrelated, one typo in a test was also fixed.

Naoto Sato has updated the pull request incrementally with one additional 
commit since the last revision:

  Reverted the typo fix

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8640/files
  - new: https://git.openjdk.java.net/jdk/pull/8640/files/0fa7cd38..d5a29e2b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=8640=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8640=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8640.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8640/head:pull/8640

PR: https://git.openjdk.java.net/jdk/pull/8640

Re: RFR: 8286287: Reading file as UTF-16 causes Error which "shouldn't happen"

2022-05-11 Thread Brian Burkhalter 
On Tue, 10 May 2022 20:22:39 GMT, Naoto Sato  wrote:

> `String.decodeWithDecoder()` method requires the `CharsetDecoder` parameter 
> replaces on malformed/unmappable characters with replacements. However, there 
> was a code path that lacked to set the `CodingErrorAction.REPLACE` on the 
> decoder. Unrelated, one typo in a test was also fixed.

Marked as reviewed by bpb (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8640

Re: RFR: 8286287: Reading file as UTF-16 causes Error which "shouldn't happen"

2022-05-11 Thread Jaikiran Pai 
On Tue, 10 May 2022 20:22:39 GMT, Naoto Sato  wrote:

> `String.decodeWithDecoder()` method requires the `CharsetDecoder` parameter 
> replaces on malformed/unmappable characters with replacements. However, there 
> was a code path that lacked to set the `CodingErrorAction.REPLACE` on the 
> decoder. Unrelated, one typo in a test was also fixed.

Marked as reviewed by jpai (Committer).

-

PR: https://git.openjdk.java.net/jdk/pull/8640

RFR: 8286287: Reading file as UTF-16 causes Error which "shouldn't happen"

2022-05-10 Thread Naoto Sato 
`String.decodeWithDecoder()` method requires the `CharsetDecoder` parameter 
replaces on malformed/unmappable characters with replacements. However, there 
was a code path that lacked to set the `CodingErrorAction.REPLACE` on the 
decoder. Unrelated, one typo in a test was also fixed.

-

Commit messages:
 - 8286287: Reading file as UTF-16 causes Error which "shouldn't happen"

Changes: https://git.openjdk.java.net/jdk/pull/8640/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8640=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8286287
  Stats: 55 lines in 3 files changed: 52 ins; 2 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8640.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8640/head:pull/8640

PR: https://git.openjdk.java.net/jdk/pull/8640