Re: RFR: 8286298: Remove unused methods in sun.invoke.util.VerifyType [v2]

2022-05-09 Thread Mandy Chung 
On Mon, 9 May 2022 10:12:36 GMT, Claes Redestad  wrote:

>> A few untested and unused methods in `VerifyType` which can be removed. 
>> (Possibly used by native JSR 292 implementations in JDK 7).
>
> Claes Redestad has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Inline isNullReferenceConversion at sole call site and remove it as well

Marked as reviewed by mchung (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8570

Re: RFR: 8286298: Remove unused methods in sun.invoke.util.VerifyType [v2]

2022-05-09 Thread Claes Redestad 
> A few untested and unused methods in `VerifyType` which can be removed. 
> (Possibly used by native JSR 292 implementations in JDK 7).

Claes Redestad has updated the pull request incrementally with one additional 
commit since the last revision:

  Inline isNullReferenceConversion at sole call site and remove it as well

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8570/files
  - new: https://git.openjdk.java.net/jdk/pull/8570/files/a456de4f..b2d1af4b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8570&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8570&range=00-01

  Stats: 19 lines in 2 files changed: 2 ins; 14 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8570.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8570/head:pull/8570

PR: https://git.openjdk.java.net/jdk/pull/8570

Re: RFR: 8286298: Remove unused methods in sun.invoke.util.VerifyType

2022-05-08 Thread Alan Bateman 
On Fri, 6 May 2022 11:32:25 GMT, Claes Redestad  wrote:

> A few untested and unused methods in `VerifyType` which can be removed. 
> (Possibly used by native JSR 292 implementations in JDK 7).

Marked as reviewed by alanb (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8570

Re: RFR: 8286298: Remove unused methods in sun.invoke.util.VerifyType

2022-05-06 Thread Brian Burkhalter 
On Fri, 6 May 2022 11:32:25 GMT, Claes Redestad  wrote:

> A few untested and unused methods in `VerifyType` which can be removed. 
> (Possibly used by native JSR 292 implementations in JDK 7).

Looks fine.

-

Marked as reviewed by bpb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8570

RFR: 8286298: Remove unused methods in sun.invoke.util.VerifyType

2022-05-06 Thread Claes Redestad 
A few untested and unused methods in `VerifyType` which can be removed. 
(Possibly used by native JSR 292 implementations in JDK 7).

-

Commit messages:
 - Remove unused methods in sun.invoke.util.VerifyType

Changes: https://git.openjdk.java.net/jdk/pull/8570/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8570&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8286298
  Stats: 72 lines in 1 file changed: 0 ins; 71 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8570.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8570/head:pull/8570

PR: https://git.openjdk.java.net/jdk/pull/8570