On Fri, 13 May 2022 12:27:16 GMT, Zhengyu Gu wrote:
> LGTM
Thanks @zhengyu123 for the review.
-
PR: https://git.openjdk.java.net/jdk/pull/8691
> Hi all,
>
> Some tests fail with Shenandoah GC after JDK-8282191.
> The reason is that the assert in `ShenandoahControlThread::request_gc` misses
> the case of `GCCause::_codecache_GC_threshold`.
> It would be better to fix it.
>
> Thanks.
> Best regards,
> Jie
Jie Fu has updated the pull
On Fri, 13 May 2022 13:18:55 GMT, David Holmes wrote:
>>> I think I agree with @AlanBateman - in the sense that this seems to go down
>>> a slippery slope where every test would need to be executed against all
>>> possible GCs. AFAIK, there are no other foreign tests doing this.
>>
>> I think
On Fri, 13 May 2022 13:02:52 GMT, Jie Fu wrote:
>> I assume you are running the tests with:
>>make run-tests TEST_OPTS_JAVA_OPTIONS="-XX:+UseShenandoahGC"
>> in which case, all of the tests you select to run will be run with that GC.
>>
>> What you have is not wrong but wouldn't be a
On Fri, 13 May 2022 06:56:23 GMT, Alan Bateman wrote:
>> Without `-XX:+UseShenandoahGC`, this bug wouldn't be exposed.
>>
>> What do you mean by `if you are testing with +ShenandoahGC then it will run
>> already`?
>
> I assume you are running the tests with:
>make run-tests
On Fri, 13 May 2022 06:56:23 GMT, Alan Bateman wrote:
>> Without `-XX:+UseShenandoahGC`, this bug wouldn't be exposed.
>>
>> What do you mean by `if you are testing with +ShenandoahGC then it will run
>> already`?
>
> I assume you are running the tests with:
>make run-tests
On Fri, 13 May 2022 02:43:55 GMT, Jie Fu wrote:
> Hi all,
>
> Some tests fail with Shenandoah GC after JDK-8282191.
> The reason is that the assert in `ShenandoahControlThread::request_gc` misses
> the case of `GCCause::_codecache_GC_threshold`.
> It would be better to fix it.
>
> Thanks.
>
On Fri, 13 May 2022 06:56:23 GMT, Alan Bateman wrote:
> I assume you are running the tests with: make run-tests
> TEST_OPTS_JAVA_OPTIONS="-XX:+UseShenandoahGC" in which case, all of the tests
> you select to run will be run with that GC.
Yes, you're right.
> What you have is not wrong but
On Fri, 13 May 2022 06:47:20 GMT, Jie Fu wrote:
>> test/jdk/java/foreign/TestIntrinsics.java line 48:
>>
>>> 46: * -XX:+UseShenandoahGC
>>> 47: * TestIntrinsics
>>> 48: */
>>
>> Is this needed? The parameters looks the same as the first test description
>> so if you are testing with
On Fri, 13 May 2022 06:36:42 GMT, Alan Bateman wrote:
>> Hi all,
>>
>> Some tests fail with Shenandoah GC after JDK-8282191.
>> The reason is that the assert in `ShenandoahControlThread::request_gc`
>> misses the case of `GCCause::_codecache_GC_threshold`.
>> It would be better to fix it.
>>
On Fri, 13 May 2022 02:43:55 GMT, Jie Fu wrote:
> Hi all,
>
> Some tests fail with Shenandoah GC after JDK-8282191.
> The reason is that the assert in `ShenandoahControlThread::request_gc` misses
> the case of `GCCause::_codecache_GC_threshold`.
> It would be better to fix it.
>
> Thanks.
>
Hi all,
Some tests fail with Shenandoah GC after JDK-8282191.
The reason is that the assert in `ShenandoahControlThread::request_gc` misses
the case of `GCCause::_codecache_GC_threshold`.
It would be better to fix it.
Thanks.
Best regards,
Jie
-
Commit messages:
-
12 matches
Mail list logo
