Re: RFR: 8287162: (zipfs) Performance regression related to support for POSIX file permissions

2022-05-24 Thread Christoph Langer
On Mon, 23 May 2022 19:47:33 GMT, Lance Andersen  wrote:

> Hi all,
> 
> This PR addresses the performance issue that is described in JDK-8287162.
> 
> With this fix,  the ZipFileSystem methods:  initOwner, initGroup, and 
> initPermissions will not be invoked unless enablePosixFileAttributes=true.  
> 
> Mach5 tiers1-3 are currently running and have not encountered any issues.

Marked as reviewed by clanger (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8854


Re: RFR: 8287162: (zipfs) Performance regression related to support for POSIX file permissions

2022-05-23 Thread Alan Bateman
On Mon, 23 May 2022 19:47:33 GMT, Lance Andersen  wrote:

> Hi all,
> 
> This PR addresses the performance issue that is described in JDK-8287162.
> 
> With this fix,  the ZipFileSystem methods:  initOwner, initGroup, and 
> initPermissions will not be invoked unless enablePosixFileAttributes=true.  
> 
> Mach5 tiers1-3 are currently running and have not encountered any issues.

Marked as reviewed by alanb (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8854


Re: RFR: 8287162: (zipfs) Performance regression related to support for POSIX file permissions

2022-05-23 Thread Jaikiran Pai
On Mon, 23 May 2022 19:47:33 GMT, Lance Andersen  wrote:

> Hi all,
> 
> This PR addresses the performance issue that is described in JDK-8287162.
> 
> With this fix,  the ZipFileSystem methods:  initOwner, initGroup, and 
> initPermissions will not be invoked unless enablePosixFileAttributes=true.  
> 
> Mach5 tiers1-3 are currently running and have not encountered any issues.

Marked as reviewed by jpai (Committer).

-

PR: https://git.openjdk.java.net/jdk/pull/8854


RFR: 8287162: (zipfs) Performance regression related to support for POSIX file permissions

2022-05-23 Thread Lance Andersen
Hi all,

This PR addresses the performance issue that is described in JDK-8287162.

With this fix,  the ZipFileSystem methods:  initOwner, initGroup, and 
initPermissions will not be invoked unless enablePosixFileAttributes=true.  

Mach5 tiers1-3 are currently running and have not encountered any issues.

-

Commit messages:
 - Only invoke initOwner, initGroup, and initPermissions when supportsPosix is 
true

Changes: https://git.openjdk.java.net/jdk/pull/8854/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8854=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8287162
  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8854.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8854/head:pull/8854

PR: https://git.openjdk.java.net/jdk/pull/8854