On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore
wrote:
> This patch tweaks the foreign API to use the newly added
> `WrongThreadException` instead of `IllegalStateException` to report
> confinement errors.
I changed the PR on our side, `IllegalStateException` is fine, if you catch it
On Wed, 25 May 2022 10:16:54 GMT, Maurizio Cimadamore
wrote:
> > Thinking more about it: `IllegalStateException` is fine for a closed
> > `MemorySession`. If used by wrong thread the exception was indeed
> > confusing. Now that the abiguity is gone, I can change our (Lucene) code
> > and
On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore
wrote:
> This patch tweaks the foreign API to use the newly added
> `WrongThreadException` instead of `IllegalStateException` to report
> confinement errors.
> Thinking more about it: `IllegalStateException` is fine for a closed
>
On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore
wrote:
> This patch tweaks the foreign API to use the newly added
> `WrongThreadException` instead of `IllegalStateException` to report
> confinement errors.
Thinking more about it: `IllegalStateException` is fine for a closed
On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore
wrote:
> This patch tweaks the foreign API to use the newly added
> `WrongThreadException` instead of `IllegalStateException` to report
> confinement errors.
I have seen this PR now: Would it be also a good idea to replace the
On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore
wrote:
> This patch tweaks the foreign API to use the newly added
> `WrongThreadException` instead of `IllegalStateException` to report
> confinement errors.
Marked as reviewed by mchung (Reviewer).
-
PR:
On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore
wrote:
> This patch tweaks the foreign API to use the newly added
> `WrongThreadException` instead of `IllegalStateException` to report
> confinement errors.
Marked as reviewed by darcy (Reviewer).
-
PR:
On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore
wrote:
> This patch tweaks the foreign API to use the newly added
> `WrongThreadException` instead of `IllegalStateException` to report
> confinement errors.
Marked as reviewed by alanb (Reviewer).
-
PR:
On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore
wrote:
> This patch tweaks the foreign API to use the newly added
> `WrongThreadException` instead of `IllegalStateException` to report
> confinement errors.
javadoc:
This patch tweaks the foreign API to use the newly added `WrongThreadException`
instead of `IllegalStateException` to report confinement errors.
-
Commit messages:
- Merge branch 'master' into wrong_thread_ex
- Initial push
Changes:
10 matches
Mail list logo