On 2013-09-11 00:00, Kumar Srinivasan wrote:
Here are the updated changes:
The build changes are here:
http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/
the delta changes since last reviewed:
http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/webrev.delta/index.html
The jdk
In SunCommandLineLauncher.java:
198 if (home.length() 0) {
199 String os_arch = System.getProperty(os.arch);
200 if (SunOS.equals(System.getProperty(os.name))) {
201 exePath = home + File.separator + bin +
File.separator + exe;
Here are the updated changes:
The build changes are here:
http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/
the delta changes since last reviewed:
http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/webrev.delta/index.html
The jdk changes are here:
On 11/09/2013 8:00 AM, Kumar Srinivasan wrote:
Here are the updated changes:
Looks okay to me.
David
The build changes are here:
http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/
the delta changes since last reviewed:
On 09/09/2013 04:28, David Holmes wrote:
:
Also:
test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-amd64/libLauncher.so
I know this already exist but I thought binaries were disallowed in
the open repo?
Right, we don't want binary files checked in. The test needs to
On 2013-09-06 18:47, Kumar Srinivasan wrote:
Hello,
Please review the changes to remove Solaris 32-bit binaries from JDK8
distros,
at this time the dual mode support in the launcher is being disabled.
Message regarding this:
Hi David,
Hi Kumar,
This is still dead code in
src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java
String os_arch = System.getProperty(os.arch);
Ah, I will take care of it. Thanks for spotting this.
Also:
On 09/09/2013 16:12, Kumar Srinivasan wrote:
Alan, are the nio changes acceptable? Let me know if you need more
time to go over all
the changes.
It looks fine (sorry I should have made that clearer). I skimmed over
the other tests too (the launcher tests in particular) and don't see any
Kumar - the makefile changes look good to me.
Tim
On 09/ 7/13 03:50 AM, Staffan Larsen wrote:
This is a welcome change. I've looked at the serviceability test and the
changes look good except:
test/demo/jvmti/DemoRun.java
test/sun/tools/jhat/HatRun.java
- Looks like there are still some
Hi Kumar,
A few minor comments ...
src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java
Seems to me this is all dead now:
199 /*
200 * A wrinkle in the environment:
201 * 64-bit executables are stored under
Hi David, Staffan, Alan,
I have addressed all the issues pointed and some more I found while jprt
testing.
The updated webrev for jdk is here:
http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk.1/
and the delta webrev since the last review webrev is here:
Hi Kumar,
This is still dead code in
src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java
String os_arch = System.getProperty(os.arch);
Also:
test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-amd64/libLauncher.so
I know this already exist but I thought
This is a welcome change. I've looked at the serviceability test and the
changes look good except:
test/demo/jvmti/DemoRun.java
test/sun/tools/jhat/HatRun.java
- Looks like there are still some -d64 remnants that I wasn't expecting.
Thanks,
/Staffan
On 6 sep 2013, at 22:17, Kumar Srinivasan
Hi Kumar,
The changes to the launcher itself and the launcher tests look good.
Thanks,
-Joe
On 9/6/2013 9:47 AM, Kumar Srinivasan wrote:
Hello,
Please review the changes to remove Solaris 32-bit binaries from JDK8
distros,
at this time the dual mode support in the launcher is being
Hello,
Please review the changes to remove Solaris 32-bit binaries from JDK8
distros,
at this time the dual mode support in the launcher is being disabled.
Message regarding this:
http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-September/003159.html
The jdk changes are here:
Another thing to consider is that there may be more modes than just
32/64 as time goes on (x32 on Intel springs to mind). Whether that's an
argument for keeping dual mode, or dropping it even faster, I'm not sure.
On 09/06/2013 12:20 PM, Martin Buchholz wrote:
Google is interested in using
On 9/6/2013 10:20 AM, Martin Buchholz wrote:
Google is interested in using DUAL_MODE on Linux and would prefer that
at least the code to support DUAL_MODE is not removed. I see that you
are not removing DUAL_MODE, just disabling it for Solaris.
correct, jdk8 will have the dual mode support.
On 06/09/2013 17:47, Kumar Srinivasan wrote:
Hello,
Please review the changes to remove Solaris 32-bit binaries from JDK8
distros,
at this time the dual mode support in the launcher is being disabled.
Message regarding this:
On 9/6/2013 12:21 PM, Alan Bateman wrote:
On 06/09/2013 17:47, Kumar Srinivasan wrote:
Hello,
Please review the changes to remove Solaris 32-bit binaries from JDK8
distros,
at this time the dual mode support in the launcher is being disabled.
Message regarding this:
Hello,
On 9/6/2013 10:20 AM, Martin Buchholz wrote:
Google is interested in using DUAL_MODE on Linux and would prefer that at
least the code to support DUAL_MODE is not removed. I see that you are not
removing DUAL_MODE, just disabling it for Solaris.
I would prefer to see DUAL_MODE
20 matches
Mail list logo
